Re: [Qemu-devel] [PATCH V19 06/12] quorum: Add quorum mechanism.

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 928 bytes --]

On 02/21/2014 03:38 PM, Kevin Wolf wrote:
>>>> +- "ret":          The IO return code.
>>>
>>> What values is this likely to contain?  Is it a finite set, in which
>>> case it would be nice to have a QAPI enum that describes the set of
>>> return codes, rather than a raw number?
>>
>> It's anything that the block stack could return as an error.
> 
> In other words, it's meaning depends on the host and the value is only
> suitable for human readers. Perhaps we could change this to strerror(),
> which is, I believe, the same as error_setg_errno() does.

Ah, so you're saying that 'ret' would be a '-errno' value - in that
case, yes, converting it to string, and documenting this field as a
human-only strerror() representation of the error would also work (using
'str', rather than an enum type).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]