From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60060) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGypL-0008FT-KE for qemu-devel@nongnu.org; Fri, 21 Feb 2014 17:44:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGypG-0002Y8-L6 for qemu-devel@nongnu.org; Fri, 21 Feb 2014 17:44:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59408) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGypG-0002Y0-CS for qemu-devel@nongnu.org; Fri, 21 Feb 2014 17:44:10 -0500 Message-ID: <5307D6B6.3050108@redhat.com> Date: Fri, 21 Feb 2014 15:44:06 -0700 From: Eric Blake MIME-Version: 1.0 References: <1393017681-12794-1-git-send-email-benoit.canet@irqsave.net> <1393017681-12794-7-git-send-email-benoit.canet@irqsave.net> <5307CEA6.5050003@redhat.com> <20140221223045.GB13076@irqsave.net> <20140221223809.GI3346@dhcp-200-207.str.redhat.com> In-Reply-To: <20140221223809.GI3346@dhcp-200-207.str.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wgAotWdWvlBpff4c1UGGQ0DFIhj5edgdl" Subject: Re: [Qemu-devel] [PATCH V19 06/12] quorum: Add quorum mechanism. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wgAotWdWvlBpff4c1UGGQ0DFIhj5edgdl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/21/2014 03:38 PM, Kevin Wolf wrote: >>>> +- "ret": The IO return code. >>> >>> What values is this likely to contain? Is it a finite set, in which >>> case it would be nice to have a QAPI enum that describes the set of >>> return codes, rather than a raw number? >> >> It's anything that the block stack could return as an error. >=20 > In other words, it's meaning depends on the host and the value is only > suitable for human readers. Perhaps we could change this to strerror(),= > which is, I believe, the same as error_setg_errno() does. Ah, so you're saying that 'ret' would be a '-errno' value - in that case, yes, converting it to string, and documenting this field as a human-only strerror() representation of the error would also work (using 'str', rather than an enum type). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --wgAotWdWvlBpff4c1UGGQ0DFIhj5edgdl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTB9a2AAoJEKeha0olJ0NqMusIALDBw6Gk5Zk4sXr2kkrWCa+0 A0RCuR9asonBgAXKbnJ14Jr0oGy894AYVIMEk/yrtOhqHNU6IbIHzBH5Q/XKImeE dnBirz5xxHVuWy5h5PADefGNLXZadEY8GJFftypeKu5TqIxkvFF6uFvt0xiltN0T 6E8jDHlFN002BHnJE9/SdQ+QWQgmAuMk7kNe+H6QXbLltVLQHgudzsBaUOOg6egc /b52x8SJQO7Qc7+OwK5kOvJ0qdRS15C2HmUo1iUuR4t/laHlsi3TqGbmGq14wwSX K6G/YsYElB0uHE+R3YVzKC1gIV6csa7kHSs30/PqYC8C8D/XDWxNFSQ7spCJTes= =omv/ -----END PGP SIGNATURE----- --wgAotWdWvlBpff4c1UGGQ0DFIhj5edgdl--