From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41205) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGzaD-0007XS-NJ for qemu-devel@nongnu.org; Fri, 21 Feb 2014 18:32:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGza8-0001De-JG for qemu-devel@nongnu.org; Fri, 21 Feb 2014 18:32:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49148) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGza8-0001DX-99 for qemu-devel@nongnu.org; Fri, 21 Feb 2014 18:32:36 -0500 Message-ID: <5307E20F.5010609@redhat.com> Date: Fri, 21 Feb 2014 16:32:31 -0700 From: Eric Blake MIME-Version: 1.0 References: <1393017681-12794-1-git-send-email-benoit.canet@irqsave.net> <1393017681-12794-7-git-send-email-benoit.canet@irqsave.net> <5307CEA6.5050003@redhat.com> <20140221223045.GB13076@irqsave.net> <20140221223809.GI3346@dhcp-200-207.str.redhat.com> <5307D6B6.3050108@redhat.com> <20140221225000.GA13587@irqsave.net> In-Reply-To: <20140221225000.GA13587@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="j2aHCcbNsGSqpXFXqWNcEUBBtroB6nKGN" Subject: Re: [Qemu-devel] [PATCH V19 06/12] quorum: Add quorum mechanism. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: Kevin Wolf , qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --j2aHCcbNsGSqpXFXqWNcEUBBtroB6nKGN Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/21/2014 03:50 PM, Beno=C3=AEt Canet wrote: > The Friday 21 Feb 2014 =C3=A0 15:44:06 (-0700), Eric Blake wrote : >> On 02/21/2014 03:38 PM, Kevin Wolf wrote: >>>>>> +- "ret": The IO return code. >>>>> >>>>> What values is this likely to contain? Is it a finite set, in whic= h >>>>> case it would be nice to have a QAPI enum that describes the set of= >>>>> return codes, rather than a raw number? >>>> >>>> It's anything that the block stack could return as an error. >>> >>> In other words, it's meaning depends on the host and the value is onl= y >>> suitable for human readers. Perhaps we could change this to strerror(= ), >>> which is, I believe, the same as error_setg_errno() does. >> >> Ah, so you're saying that 'ret' would be a '-errno' value - in that >> case, yes, converting it to string, and documenting this field as a >> human-only strerror() representation of the error would also work (usi= ng >> 'str', rather than an enum type). >=20 > How do I proceed ? >=20 > Should I respin the serie ? Or do a follow up patch ?=20 Followup is fine, as long as we get it done before 2.0. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --j2aHCcbNsGSqpXFXqWNcEUBBtroB6nKGN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTB+IPAAoJEKeha0olJ0NqBScH/Rslp6vPu/XFHEsYKGwAf89s c8U4Z5k7hBbv83VxiebwDWXi8RnyHwhJPKT/Qx962JcnM5JPtXQ9bhIxFf2SlUO7 T1rkjjIuyUOYszkyIvPPBlFd+Hz0EPPfBxJyGFF/R/QsbFzUvXIKWXXP2ZtioVCF yXIJ4670ICwin2xv5ZlHi1WRqPJ1KBESYPdm4aCOp3ZrISCJlBARgeteD0lRcv7J kfkw8P4bCP8Uue+Fw0io7ok4VxH2jngY8NhRUvIExsg2MncT4KmCS01n9kbJ9IBt Ax4i+oqqHE9fO6fGP6mCs9xwcbcQX9qv/AMaGKKdGUTPVBqEA+cSB8TvWQrVHJM= =aRTb -----END PGP SIGNATURE----- --j2aHCcbNsGSqpXFXqWNcEUBBtroB6nKGN--