Re: [Qemu-devel] [PATCH v7 0/2] target-ppc: CPU device tree id

[Alexey Kardashevskiy <aik@ozlabs.ru>]

On 02/22/2014 01:51 PM, Benjamin Herrenschmidt wrote:
> On Sat, 2014-02-22 at 13:20 +1100, Alexey Kardashevskiy wrote:
> 
>> Sorry for bothering again. This is quite simple patchset, it does not touch
>> a lot and just a small rework. This is v7, v1 was 31/10/2013 (~4 months), I
>> sent "ping" to v5 5 times (took 2 months to get any attention), there was
>> no comment that it breaks anything, few people commented that the patchset
> 
> "few people", you should name them. And they should ack it if they are
> ok with it.


Nobody specifically did "acked-by". Mike Day "would ack them if it would
help", Andreas Färber has "No objection from my side, but I'm not really
familiar with the topic", others commented some older versions and did not
comment newer fixed versions. This is my confusion.

Should I personally ask everyone who commented to re-review new version again?

> 
>> is ok, we use it internally for quite a while but it is still not in any
>> tree but mine. I have other patchsets like that and I am not posting new
>> ones because I do not really see the point until I figure out what is wrong
>> with my old patches or with the way I posting them and trying to get attention.
>>
>> If anyone feels ok to "ack" these patches, please do so. Thanks and sorry
>> again.
>>
>>
>>>>
>>>>>
>>>>> Changes:
>>>>> v7:
>>>>> * cleaned up a bit of QOM use
>>>>>
>>>>> v6:
>>>>> * removed kvmppc_fixup_cpu()
>>>>>
>>>>> v5:
>>>>> * cleanup
>>>>> * removed cpustate::kvm_cpu_id
>>>>> * split into 2 patches - new PPC API and the usage of the API
>>>>>
>>>>>
>>>>> Alexey Kardashevskiy (2):
>>>>>   target-ppc: add PowerPCCPU::cpu_dt_id
>>>>>   target-ppc: spapr: e500: fix to use cpu_dt_id
>>>>>
>>>>>  hw/intc/openpic_kvm.c       |  2 +-
>>>>>  hw/intc/xics.c              | 15 +++++++++++++--
>>>>>  hw/intc/xics_kvm.c          | 10 +++++-----
>>>>>  hw/ppc/e500.c               |  7 +++++--
>>>>>  hw/ppc/ppc.c                | 22 ++++++++++++++++++++++
>>>>>  hw/ppc/spapr.c              |  9 +++++----
>>>>>  hw/ppc/spapr_hcall.c        |  6 +++---
>>>>>  hw/ppc/spapr_rtas.c         | 14 +++++++-------
>>>>>  target-ppc/cpu-qom.h        |  2 ++
>>>>>  target-ppc/cpu.h            | 18 ++++++++++++++++++
>>>>>  target-ppc/kvm.c            | 15 +--------------
>>>>>  target-ppc/kvm_ppc.h        |  6 ------
>>>>>  target-ppc/translate_init.c | 11 +++++------
>>>>>  13 files changed, 87 insertions(+), 50 deletions(-)
>>>>>
>>>>
>>>>
>>>
>>>
>>
>>
> 
> 


-- 
Alexey