From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38096)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xbing6list@gmail.com>) id 1WHQ1L-0005qa-Ca
	for qemu-devel@nongnu.org; Sat, 22 Feb 2014 22:46:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xbing6list@gmail.com>) id 1WHQ1C-0002kW-Ug
	for qemu-devel@nongnu.org; Sat, 22 Feb 2014 22:46:27 -0500
Received: from mail-pd0-x236.google.com ([2607:f8b0:400e:c02::236]:62727)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xbing6list@gmail.com>) id 1WHQ1C-0002kR-Ng
	for qemu-devel@nongnu.org; Sat, 22 Feb 2014 22:46:18 -0500
Received: by mail-pd0-f182.google.com with SMTP id v10so4892830pde.13
	for <qemu-devel@nongnu.org>; Sat, 22 Feb 2014 19:46:17 -0800 (PST)
Message-ID: <53096EFC.9040001@gmail.com>
Date: Sun, 23 Feb 2014 11:46:04 +0800
From: Xuebing Wang <xbing6list@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel]  Questions about timer
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: QEMU Developers <qemu-devel@nongnu.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Alex Bligh <alex@alex.org.uk>, Stefan Hajnoczi <stefanha@redhat.com>

Hi Community,

I am new to qemu, I am trying to familiarize myself with aarch64 
timer/interrupt support (maybe someone already did this, but not merged 
into mainline yet).

As shown in include/qemu/timer.h, there are 6 categories of APIs:
- QEMUClockType
- QEMUTimerList
- QEMUTimerListGroup
- QEMUTimer
- General utility functions
- Low level clock functions

I have a few questions:

Q1) All QEMUTimerList functions are private to qemu-timer.c. Can we make 
them static and remove them from include/qemu/timer.h because they are 
NOT APIs?

Q2) The implementation of other categories of API functions are kind of 
inter-wined, does it make sense to re-organize them in qemu-timer.c, and 
make them strictly follow the sequence in include/qemu/timer.h?

Q3) Below functions are NOT implemented in qemu-timer.c, but declared in 
include/qemu/timer.h, should we address this?
- qemu_clock_warp
- timer_get and timer_put
- cpu_get_ticks, cpu_enable_ticks, cpu_disable_ticks

Q4) Do we need this API qemu_clock_get_main_loop_timerlist?

-- 
Thanks,
Xuebing Wang