From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48630)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WHriB-0008Al-5Y
	for qemu-devel@nongnu.org; Mon, 24 Feb 2014 04:20:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WHri4-00055q-Aw
	for qemu-devel@nongnu.org; Mon, 24 Feb 2014 04:20:31 -0500
Received: from mx1.redhat.com ([209.132.183.28]:55135)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WHri4-00055k-1X
	for qemu-devel@nongnu.org; Mon, 24 Feb 2014 04:20:24 -0500
Message-ID: <530B0ECB.8080608@redhat.com>
Date: Mon, 24 Feb 2014 10:20:11 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1393233201-3636-1-git-send-email-orx.goshen@intel.com>
In-Reply-To: <1393233201-3636-1-git-send-email-orx.goshen@intel.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Support NBD client under win32/MinGW
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Or Goshen <oberonc@gmail.com>
Cc: qemu-devel@nongnu.org

Il 24/02/2014 10:13, Or Goshen ha scritto:
>
> +		/* Create event */
> +		HANDLE event = WSACreateEvent();
> +		long lNetworkEvents = 0;
> +
> +		if (node->io_read)
> +			lNetworkEvents |= FD_READ;
> +		if (node->io_write)
> +			lNetworkEvents |= FD_WRITE;
> +
> +		WSAEventSelect(node->pfd.fd, event, lNetworkEvents);
> +		node->e = (EventNotifier *)event;

As mentioned on IRC, I'd like you to try using the EventNotifier of the 
AioContext.  You shouldn't need any of these casts.

>  ifeq ($(CONFIG_POSIX),y)
> -block-obj-y += nbd.o nbd-client.o sheepdog.o
> +block-obj-y += nbd-client.o sheepdog.o

nbd-client.c must be compiled on Windows, too.

In fact I think you can just drop the ifeq/endif directives.

>  block-obj-$(CONFIG_LIBISCSI) += iscsi.o
>  block-obj-$(CONFIG_CURL) += curl.o
>  block-obj-$(CONFIG_RBD) += rbd.o

Also, the patch has wrong indentation.  We use 4 space indentation, and 
never use tabs.

Paolo