From: "Andreas Färber" <afaerber@suse.de>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: "Vassili Karpov (malc)" <av1474@comtv.ru>
Subject: Re: [Qemu-devel] [PULL 1/1] hda-audio: qom cleanups
Date: Mon, 24 Feb 2014 13:32:24 +0100 [thread overview]
Message-ID: <530B3BD8.4030204@suse.de> (raw)
In-Reply-To: <1393244541-29715-2-git-send-email-kraxel@redhat.com>
Am 24.02.2014 13:22, schrieb Gerd Hoffmann:
> Add HDA_AUDIO type and macro, drop DO_UPCAST().
>
> Had to add a abstract hda audio class as parent
> for all hda-* variants to make that fly. Killed
> some init code duplication while being at it.
>
> Cc: Andreas Färber <afaerber@suse.de>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> hw/audio/hda-codec.c | 60 ++++++++++++++++++++++++++++------------------------
> 1 file changed, 32 insertions(+), 28 deletions(-)
Looks good, including introduction of a base type, thanks for cleaning
this up. These devices are not used by default, right? Have you been
considering writing qtests for them or would you rather have me prepare
something?
Cheers,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2014-02-24 12:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 12:22 [Qemu-devel] [PULL 0/1] audio patch queue Gerd Hoffmann
2014-02-24 12:22 ` [Qemu-devel] [PULL 1/1] hda-audio: qom cleanups Gerd Hoffmann
2014-02-24 12:32 ` Andreas Färber [this message]
2014-02-24 12:40 ` Gerd Hoffmann
2014-02-26 18:31 ` [Qemu-devel] [PULL 0/1] audio patch queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530B3BD8.4030204@suse.de \
--to=afaerber@suse.de \
--cc=av1474@comtv.ru \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).