From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50108)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1WHvtq-00037F-QY
	for qemu-devel@nongnu.org; Mon, 24 Feb 2014 08:48:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pl@kamp.de>) id 1WHvtg-0004Ay-VP
	for qemu-devel@nongnu.org; Mon, 24 Feb 2014 08:48:50 -0500
Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:48576 helo=mx01.kamp.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1WHvtg-0004AO-Jk
	for qemu-devel@nongnu.org; Mon, 24 Feb 2014 08:48:40 -0500
Message-ID: <530B4DAA.6070301@kamp.de>
Date: Mon, 24 Feb 2014 14:48:26 +0100
From: Peter Lieven <pl@kamp.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] compressed VMDKs and BDRV_BLOCK_OFFSET_VALID
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Fam Zheng <famz@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

Hi,

I wonder if the current output of get_block_status for compressed VMDKs is correct or
if we need this patch?:

diff --git a/block/vmdk.c b/block/vmdk.c
index ff6f5ee..5fa29b0 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -1146,7 +1146,7 @@ static int64_t coroutine_fn vmdk_co_get_block_status(BlockDriverState *bs,
          break;
      case VMDK_OK:
          ret = BDRV_BLOCK_DATA;
-        if (extent->file == bs->file) {
+        if (extent->file == bs->file && !extent->compressed) {
              ret |= BDRV_BLOCK_OFFSET_VALID | offset;
          }

Peter