From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52184)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WHxst-0006DD-Sj
	for qemu-devel@nongnu.org; Mon, 24 Feb 2014 10:56:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WHxsl-0002wo-UM
	for qemu-devel@nongnu.org; Mon, 24 Feb 2014 10:55:59 -0500
Received: from cantor2.suse.de ([195.135.220.15]:52614 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WHxsl-0002wT-PH
	for qemu-devel@nongnu.org; Mon, 24 Feb 2014 10:55:51 -0500
Message-ID: <530B6B84.9010204@suse.de>
Date: Mon, 24 Feb 2014 16:55:48 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1392737293-10073-1-git-send-email-peter.maydell@linaro.org>	<5306FD28.8000104@web.de>
	<CAFEAcA_a4CqBum9XVo_G7Xa3oC0OzmANeRx103tDBEoLmSRrHQ@mail.gmail.com>
In-Reply-To: <CAFEAcA_a4CqBum9XVo_G7Xa3oC0OzmANeRx103tDBEoLmSRrHQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] hw/arm/musicpal: Remove nonexistent CDTP2,
 CDTP3 registers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, Jan Kiszka <jan.kiszka@web.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Patch Tracking <patches@linaro.org>

Am 24.02.2014 16:45, schrieb Peter Maydell:
> On 21 February 2014 07:15, Jan Kiszka <jan.kiszka@web.de> wrote:
>> On 2014-02-18 16:28, Peter Maydell wrote:
>>> The ethernet device in the musicpal only has two tx queues,
>>> but we modelled it with four CTDP registers, presumably a
>>> cut and paste from the rx queue registers. Since the tx_queue[]
>>> array is only 2 entries long this allowed a guest to overrun
>>> this buffer. Remove the nonexistent registers.
>>>
>>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>>
>> Acked-by: Jan Kiszka <jan.kiszka@web.de>
>=20
> Thanks, applied to target-arm.next (with added cc:stable line).

Jan/Peter, is there any other outstanding work on musicpal that I should
be aware of? If not, I'd like to base the long-planned file splitup on
Peter's next pull. Hopefully we can still get that done for 2.0.

Cheers,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg