From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35224) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WI0Ar-0001Vn-QZ for qemu-devel@nongnu.org; Mon, 24 Feb 2014 13:22:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WI0Al-0000c6-SE for qemu-devel@nongnu.org; Mon, 24 Feb 2014 13:22:41 -0500 Sender: Richard Henderson Message-ID: <530B8DDD.4030501@twiddle.net> Date: Mon, 24 Feb 2014 10:22:21 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1392240199-2454-1-git-send-email-tommusta@gmail.com> <1392240199-2454-27-git-send-email-tommusta@gmail.com> <530B8883.5050908@twiddle.net> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 26/28] target-ppc: Altivec 2.07: AES Instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Tom Musta , "qemu-ppc@nongnu.org" , QEMU Developers On 02/24/2014 10:11 AM, Peter Maydell wrote: > On 24 February 2014 17:59, Richard Henderson wrote: >> I'll also note that arm contains a second copy of the aes_{i,}shifts arrays. >> So after those are moved to common code, we avoid that duplication too. > > AIUI this duplication was because the utils/ code wasn't suitable > for ARM; Ard's rationale is here: > http://lists.gnu.org/archive/html/qemu-devel/2013-12/msg01789.html That's about sbox vs AES_Te*. In the bit you quote, I'm talking about aes_shift[] vs shift[0][] and aes_ishift[] vs shift[1][], in the i386 and arm backends respectively. And arguing that data should be moved to utils/ so that it can be shared between i386, arm, and ppc. In a bit you don't quote, I argue that arm's sbox array should be moved to utils/ so that it can be shared with ppc, which will need it for its "vsbox" instruction. I don't really have an opinion on arm's MixColumns lookup table. r~