From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Jan Kiszka <jan.kiszka@web.de>,
QEMU Developers <qemu-devel@nongnu.org>,
Patch Tracking <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] hw/arm/musicpal: Remove nonexistent CDTP2, CDTP3 registers
Date: Mon, 24 Feb 2014 19:50:24 +0100 [thread overview]
Message-ID: <530B9470.3050200@suse.de> (raw)
In-Reply-To: <CAFEAcA_X4aZd_s_EKmTCdu_LjkGdfohiriZfMBQ_Bn=DZCfEoA@mail.gmail.com>
Am 24.02.2014 17:02, schrieb Peter Maydell:
> On 24 February 2014 15:55, Andreas Färber <afaerber@suse.de> wrote:
>> Jan/Peter, is there any other outstanding work on musicpal that I should
>> be aware of? If not, I'd like to base the long-planned file splitup on
>> Peter's next pull. Hopefully we can still get that done for 2.0.
>
> I have a trivial patch on list for it:
> http://patchwork.ozlabs.org/patch/322857/
>
> which I'm probably not going to put into my next pull unless
> somebody reviews those patches since they've not been on
> list very long. Other than that I'm not aware of anything.
Maybe Jan as author can review it? :)
> (I can trivially rebase that on top of a file split, obviously.)
>
> I assume you just mean splitting the devices currently in
> hw/arm/musicpal.c out into their own files?
Yes, in particular I had noticed that the NIC (which your linked patch
indeed seems to be touching) was missing in hw/net/, we had previously
talked about doing this. Now that we have qom-test for musicpal and the
Soft Freeze coming up might be a good time to finally do this.
Cheers,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2014-02-24 18:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 15:28 [Qemu-devel] [PATCH] hw/arm/musicpal: Remove nonexistent CDTP2, CDTP3 registers Peter Maydell
2014-02-21 7:15 ` Jan Kiszka
2014-02-24 15:45 ` Peter Maydell
2014-02-24 15:55 ` Andreas Färber
2014-02-24 16:02 ` Peter Maydell
2014-02-24 18:50 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530B9470.3050200@suse.de \
--to=afaerber@suse.de \
--cc=jan.kiszka@web.de \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).