From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55983) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIDGI-0005Hc-IH for qemu-devel@nongnu.org; Tue, 25 Feb 2014 03:21:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WIDG8-0002JU-LY for qemu-devel@nongnu.org; Tue, 25 Feb 2014 03:21:10 -0500 Sender: Paolo Bonzini Message-ID: <530C5265.4040900@redhat.com> Date: Tue, 25 Feb 2014 09:20:53 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1393174935-11750-1-git-send-email-sw@weilnetz.de> <530C2AE2.1010003@weilnetz.de> In-Reply-To: <530C2AE2.1010003@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/9] w32: Reduce dependency on Windows API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil , qemu-devel@nongnu.org Cc: qemu-trivial , Peter Maydell Il 25/02/2014 06:32, Stefan Weil ha scritto: > Am 23.02.2014 18:02, schrieb Stefan Weil: >> Today, most .o files depend on windows.h when QEMU is built with MinGW or >> MinGW-w64 (32 and 64 bit builds). These patches reduce the number of such >> files from more than 1800 to less than 180. They also allow removing some >> hacks which were needed because of conflicts with windows.h. A nasty >> compiler warning is fixed, too. >> >> The modifications were tested with MinGW (32 bit native) and MinGW-w64 >> (32 and 64 bit cross). >> >> Regards >> Stefan W. >> >> [PATCH 1/9] util/iov: Use qemu/sockets.h instead of conditional code >> [PATCH 2/9] exec: Remove unneeded include files >> [PATCH 3/9] qemu-img: Remove unneeded include files >> [PATCH 4/9] qga: Remove unneeded include file >> [PATCH 5/9] vl: Remove unneeded include file >> [PATCH 6/9] w32: Add and use intermediate include file for windows.h >> [PATCH 7/9] w32: Move inline function from header file to C source >> [PATCH 8/9] w32: Reduce dependencies in sysemu/os-win32.h >> [PATCH 9/9] w32: Replace Windows specific data types in common >> > > This patch series needs at least one more iteration with a v2. > > Patches 1-5 can be applied independently of the rest and are trivial, so > maybe they can be applied by qemu-trivial, or I can send a pull request > for only those patches as soon as they were reviewed. That would reduce > the size of my v2 patch set. Patches 1-5 are Reviewed-by: Paolo Bonzini Thanks for all the effort you put in janitorial work, it's as thankless as it's useful! Paolo