qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: "Andreas Färber" <afaerber@suse.de>,
	"Romain Dolbeau" <romain@dolbeau.org>,
	qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] Drop legacy device lists? (was: [PATCH] e1000: add the ability to select among several specific types of e1000 ...)
Date: Tue, 25 Feb 2014 19:26:37 +0100	[thread overview]
Message-ID: <530CE05D.50209@weilnetz.de> (raw)
In-Reply-To: <530C4DC0.6000506@suse.de>

Am 25.02.2014 09:01, schrieb Andreas Färber:
> Hi,
>
> Am 24.02.2014 20:08, schrieb Romain Dolbeau:
[...]
>> diff --git a/hw/pci/pci.c b/hw/pci/pci.c
>> index 4e0701d..07c8cdd 100644
>> --- a/hw/pci/pci.c
>> +++ b/hw/pci/pci.c
>> @@ -1572,6 +1572,9 @@ static const char * const pci_nic_models[] = {
>>      "i82559er",
>>      "rtl8139",
>>      "e1000",
>> +    "82540EM",
>> +    "82544GC",
>> +    "82545EM",
>>      "pcnet",
>>      "virtio",
>>      NULL
>> @@ -1584,6 +1587,9 @@ static const char * const pci_nic_names[] = {
>>      "i82559er",
>>      "rtl8139",
>>      "e1000",
>> +    "82540EM",
>> +    "82544GC",
>> +    "82545EM",
>>      "pcnet",
>>      "virtio-net-pci",
>>      NULL
> I would hope that adding to these two legacy lists is not necessary for
> new types. They should be created using -device, not -net nic,model=.
>
> Regards,
> Andreas

What about removing those lists for QEMU 2.0? We should use the version
update to get rid of some legacy interfaces.

Stefan

      parent reply	other threads:[~2014-02-25 18:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-24 19:08 [Qemu-devel] [PATCH] e1000: add the ability to select among several specific types of e1000, plus some pointers to documentations and details Romain Dolbeau
2014-02-25  3:26 ` [Qemu-devel] [PATCH] e1000: add the ability to select among Gabriel L. Somlo
2014-02-25  8:01 ` [Qemu-devel] [PATCH] e1000: add the ability to select among several specific types of e1000, plus some pointers to documentations and details Andreas Färber
2014-02-25  8:58   ` Romain Dolbeau
2014-02-25  9:24     ` Romain Dolbeau
2014-02-27 15:16       ` Stefan Hajnoczi
2014-02-25 18:26   ` Stefan Weil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=530CE05D.50209@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=afaerber@suse.de \
    --cc=qemu-devel@nongnu.org \
    --cc=romain@dolbeau.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).