From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56649) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIenV-0006qy-6v for qemu-devel@nongnu.org; Wed, 26 Feb 2014 08:45:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WIenO-00055a-SC for qemu-devel@nongnu.org; Wed, 26 Feb 2014 08:45:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34716) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIenO-00055M-LD for qemu-devel@nongnu.org; Wed, 26 Feb 2014 08:45:10 -0500 Message-ID: <530DEFDD.9060305@redhat.com> Date: Wed, 26 Feb 2014 14:45:01 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1391674564-3783-1-git-send-email-imammedo@redhat.com> <1391674564-3783-3-git-send-email-imammedo@redhat.com> <52F90EB3.8030902@redhat.com> <530DEC52.9030901@redhat.com> <530DEF48.6060509@redhat.com> In-Reply-To: <530DEF48.6060509@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] vl: convert -m to QemuOpts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: kwolf@redhat.com, aliguori@amazon.com, mjt@tls.msk.ru, armbru@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, lcapitulino@redhat.com, Igor Mammedov , akong@redhat.com Il 26/02/2014 14:42, Laszlo Ersek ha scritto: > When you have a QemuOpt that takes an argument, then the documentation > of the default behavior usually explains the case when the QemuOpt is > present, and the argument is absent. The documentation of the default > behavior usually doesn't concern the case when the QemuOpt*s* itself is > absent. Cf. > > (1) -foo bar > (2) -foo bar=baz > (3) [nothing] > > The "default" in the docs tends to explain case (1), not case (3). > > In this case we have: -m [mem=]megs > > (1) -m mem -- makes no sense > (2) -m mem=megs -- works, and well documented > (3) [nothing] -- is what the proposed docs describe as "default", but it > doesn't match "historical practice". > > (1) in general can make sense, eg. for booleans. > > Anyway I don't feel strongly about this in the least -- I just thought > I'd point it out. Yeah, you're right. > Feel free to ignore it; I have no good suggestion as > to how to make it consistent across all options. Neither do I, but at least "megs" is not marked as an optional element, so I think it's not that ambiguous. Paolo