Re: [Qemu-devel] [PATCH v2 0/5] s390: Support for Hotplug of Standby Memory

[Christian Borntraeger <borntraeger@de.ibm.com>]

On 26/02/14 15:45, Paolo Bonzini wrote:
> Il 26/02/2014 15:42, Christian Borntraeger ha scritto:
>> On 24/02/14 22:30, Matthew Rosato wrote:
>>> This patchset adds support in s390 for a pool of standby memory,
>>> which can be set online/offline by the guest (ie, via chmem).
>>> New options, maxmem and slots, are added to the QEMU command line
>>> memory parameter to specify the total amount of memory available
>>> to the guest as well as the number of memory slots available.
>>> As part of this work, additional results are provided for the
>>> Read SCP Information SCLP, and new implentation is added for the
>>> Read Storage Element Information, Attach Storage Element,
>>> Assign Storage and Unassign Storage SCLPs, which enables the s390
>>> guest to manipulate the standby memory pool.
>>
>> Looks like Paolo will apply Igors latest patches to the numa branch,
>> I will defer patches 3-5 until Igors patches hit qemu master.
> 
> What are the dependencies of these series?  I can include it in my queue if:

The last version of the "memory hotplug" platches (its actually concept called
standby memory that the guest can request to be enabled from the hypervisor)
gained feedback from you to use Igors patch set instead of cooking up a new parameter
(http://lists.gnu.org/archive/html/qemu-devel/2013-12/msg03081.html)

Seems that the latest version
(https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg02321.html)
does not match the patch in this series.

I have not fully reviewed patches 3-5 yet, so lets just defer memory hotplug
on s390 until Igors patch hit master.

Christian

> 
> (a) you give me your Acked-by
> 
> (b) Igor reviews it and tells me if this is the right version of his patch "extend -m option to support options for memory hotplug"
> 
> Paolo
> 
>> Christian
>>
>>>
>>> This patchset is based on work originally done by Jeng-Fang (Nick)
>>> Wang.
>>>
>>> This patchset has been built to apply on the s390-next tree at:
>>>
>>> git://github.com/borntraeger/qemu.git s390-next
>>>
>>> Changes for v2:
>>>  * Removed the patch that introduced the standby-mem operand and
>>>    instead included Igor Mammedov's patches that add the mem-opts
>>>    'maxmem' and 'slots', with a slight modification due to the removal
>>>    of qemu_opts_create_nofail.
>>>  * Patch 3 was inserted to add a new qom object that encapsulate variables
>>>    used by s390 memory hotplug.  Patches 4 and 5 adjusted to use this
>>>    object.
>>>  * Added additional code comments and other minor changes per Alexander
>>>    Graf's comments
>>>
>>> Igor Mammedov (2):
>>>   vl: convert -m to QemuOpts
>>>   vl.c: extend -m option to support options for memory hotplug
>>>
>>> Matthew Rosato (3):
>>>   sclp-s390: Add device to manage s390 memory hotplug
>>>   virtio-ccw: Include standby memory when calculating storage increment
>>>   sclp-s390: Add memory hotplug SCLPs
>>>
>>>  hw/s390x/s390-virtio-ccw.c |   42 +++++--
>>>  hw/s390x/sclp.c            |  276 ++++++++++++++++++++++++++++++++++++++++++--
>>>  include/hw/s390x/sclp.h    |   19 +++
>>>  qemu-options.hx            |   10 +-
>>>  target-s390x/cpu.h         |   18 +++
>>>  target-s390x/kvm.c         |    5 +
>>>  vl.c                       |   98 ++++++++++++++--
>>>  7 files changed, 440 insertions(+), 28 deletions(-)
>>>
>>
>