From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59230)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1WIk4T-0007Hh-6Z
	for qemu-devel@nongnu.org; Wed, 26 Feb 2014 14:23:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1WIk4J-0003gE-BD
	for qemu-devel@nongnu.org; Wed, 26 Feb 2014 14:23:09 -0500
Message-ID: <530E3F09.8020904@gmail.com>
Date: Wed, 26 Feb 2014 13:22:49 -0600
From: Tom Musta <tommusta@gmail.com>
MIME-Version: 1.0
References: <1392240199-2454-1-git-send-email-tommusta@gmail.com>
	<1392240199-2454-27-git-send-email-tommusta@gmail.com>
	<530B8883.5050908@twiddle.net>
In-Reply-To: <530B8883.5050908@twiddle.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 26/28] target-ppc: Altivec 2.07: AES
	Instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-ppc@nongnu.org

On 2/24/2014 11:59 AM, Richard Henderson wrote:
> On 02/12/2014 01:23 PM, Tom Musta wrote:
>> +static uint8_t SBOX[256] = {
> 
> I'm not keen on yet another copy of AES data.
> 
> Please reuse "qemu/aes.h" as much as possible.  Please see how we use those in
> target-i386; from a quick reading, these insns should match up:
> 
>   aesenc	vcipher
>   aesenclast	vcipherlast
>   aesdec	vncipher
>   aesdeclast	vncipherlast
> 
> It does look like the aes_shifts/aes_ishifts arrays should be moved from i386
> specific code.  Which would also be good since ops_sse.h is included multiple
> times and thus we have unnecessary multiple copies of this data.
> 
> There's more data that should be moved out to common code in
> target-arm/crypto_helper.c.  The most pertinent of which is a copy of your SBOX
> and InvSBOX arrays, which you'll still need for the vsbox insn.
> 
> I'll also note that arm contains a second copy of the aes_{i,}shifts arrays.
> So after those are moved to common code, we avoid that duplication too.
> 
> 
> r~
> 

Richard,

Thanks for the feedback ... this is a good suggestion.

I see one problem with the PowerPC vncipher instruction.  This instruction is
not equivalent the aesdec.  Moreover, the AddRoundKey (XOR) is performed *before*
applying the InvMixColumns operation.  So the AES_Te4 mapping is not correct
for PPC.