From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35316)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1WImcV-00005b-Au
	for qemu-devel@nongnu.org; Wed, 26 Feb 2014 17:06:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1WImcM-0007H2-Tv
	for qemu-devel@nongnu.org; Wed, 26 Feb 2014 17:06:27 -0500
Message-ID: <530E6554.60008@gmail.com>
Date: Wed, 26 Feb 2014 16:06:12 -0600
From: Tom Musta <tommusta@gmail.com>
MIME-Version: 1.0
References: <1392240199-2454-1-git-send-email-tommusta@gmail.com>
	<1392240199-2454-27-git-send-email-tommusta@gmail.com>
	<530B8883.5050908@twiddle.net> <530E3F09.8020904@gmail.com>
In-Reply-To: <530E3F09.8020904@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 26/28] target-ppc: Altivec 2.07: AES
	Instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-ppc@nongnu.org

On 2/26/2014 1:22 PM, Tom Musta wrote:
> I see one problem with the PowerPC vncipher instruction.  This instruction is
> not equivalent the aesdec.  Moreover, the AddRoundKey (XOR) is performed *before*
> applying the InvMixColumns operation.  So the AES_Te4 mapping is not correct
> for PPC.

s/AES_Te4/AES_Te*/

And I should have added ...

Even though I cannot use AES_Te4, I certainly can construct a flattened table
for InvMixColumns (a la AES_T*).  This will result in a faster implementation.

Does it make sense to put this InvMixColumns table in common utilities even
if PowerPC is the only user?  It seems to be mainly an issue of space (about 4K).