From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32798) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIxzt-0008Sv-Ql for qemu-devel@nongnu.org; Thu, 27 Feb 2014 05:15:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WIxzo-0005Q4-Pv for qemu-devel@nongnu.org; Thu, 27 Feb 2014 05:15:21 -0500 Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:60803 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIxzo-0005Ph-Eg for qemu-devel@nongnu.org; Thu, 27 Feb 2014 05:15:16 -0500 Message-ID: <530F102E.7050307@kamp.de> Date: Thu, 27 Feb 2014 11:15:10 +0100 From: Peter Lieven MIME-Version: 1.0 References: <1393408077-556-1-git-send-email-pl@kamp.de> <20140226101731.GA5760@T430.nay.redhat.com> <20140227100628.GB30387@stefanha-thinkpad.redhat.com> In-Reply-To: <20140227100628.GB30387@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block/vmdk: do not report file offset for compressed extents List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , Fam Zheng Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com Am 27.02.2014 11:06, schrieb Stefan Hajnoczi: > On Wed, Feb 26, 2014 at 06:17:31PM +0800, Fam Zheng wrote: >> On Wed, 02/26 10:47, Peter Lieven wrote: >>> Signed-off-by: Peter Lieven >>> --- >>> block/vmdk.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/block/vmdk.c b/block/vmdk.c >>> index ff6f5ee..5fa29b0 100644 >>> --- a/block/vmdk.c >>> +++ b/block/vmdk.c >>> @@ -1146,7 +1146,7 @@ static int64_t coroutine_fn vmdk_co_get_block_status(BlockDriverState *bs, >>> break; >>> case VMDK_OK: >>> ret = BDRV_BLOCK_DATA; >>> - if (extent->file == bs->file) { >>> + if (extent->file == bs->file && !extent->compressed) { >>> ret |= BDRV_BLOCK_OFFSET_VALID | offset; >>> } >>> >>> -- >>> 1.7.9.5 >>> >> Reviewed-by: Fam Zheng > I don't have the original mail :(. Did it get sent out the mailing > list? > > All patches must be posted to qemu-devel@nongnu.org so they can be > reviewed by the community before being merged. Please send top-level > mails, don't send new patches as a reply to another thread. > > Stefan I know. I've sent this patch out to qemu-devel@nongnu.org. Very strange. I will repost. Peter