From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJ1E0-00082I-KB for qemu-devel@nongnu.org; Thu, 27 Feb 2014 08:42:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WJ1Dv-0000fs-Ni for qemu-devel@nongnu.org; Thu, 27 Feb 2014 08:42:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47136) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJ1Dv-0000fg-FE for qemu-devel@nongnu.org; Thu, 27 Feb 2014 08:42:03 -0500 Message-ID: <530F40A9.4000208@redhat.com> Date: Thu, 27 Feb 2014 06:42:01 -0700 From: Eric Blake MIME-Version: 1.0 References: <155481d240779c5d25f8195a406d57db613507bc.1393407651.git.amit.shah@redhat.com> <20140227101815.GC30387@stefanha-thinkpad.redhat.com> <20140227113312.GA30957@grmbl.mre> In-Reply-To: <20140227113312.GA30957@grmbl.mre> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SfpnJSgHfndSHnDlLBhW4gPfPNjOFfORv" Subject: Re: [Qemu-devel] [PATCH 1/1] block: use /var/tmp instead of /tmp for -snapshot List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah , Stefan Hajnoczi Cc: Kevin Wolf , qemu list , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SfpnJSgHfndSHnDlLBhW4gPfPNjOFfORv Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/27/2014 04:33 AM, Amit Shah wrote: > On (Thu) 27 Feb 2014 [11:18:15], Stefan Hajnoczi wrote: >> On Wed, Feb 26, 2014 at 03:12:37PM +0530, Amit Shah wrote: >>> If TMPDIR is not specified, the default was to use /tmp for the worki= ng >>> copy of the block devices. Update this to /var/tmp instead, so syste= ms >>> using tmp-on-tmpfs don't end up inadvertently using RAM for the block= >>> device. >>> >>> Signed-off-by: Amit Shah >>> --- >>> block.c | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> Was expecting someone to argue against this because a path change is >> always controversial :-). But I think this makes sense and no one is >> protesting.... No protests here. Libvirt doesn't use -snapshot to trigger the behavior in the first place, and even if it did, it is always possible to explicitly set TMPDIR if you don't like the (changed) default. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --SfpnJSgHfndSHnDlLBhW4gPfPNjOFfORv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTD0CpAAoJEKeha0olJ0NqOMMH/1uAZQ07GqJHvGmM6Btzr3XE Of3DLsSzWMkeape2yJZ8ggIOCXckFgvXTX8f/pYFp8KolCEJQkaZCtBLuMp3iGDZ BJJWLZcHh6mWNa9s1g07/xizBT5ohX7ykNKyp3aeAwynwGQyL+Zta21pvCYrHKnt CKBpTT1KnHJGQI25viEyn/qWWCbTfr2mqcxZp/W1EbgElDITGpIbdNAuDtGLqVzu Kgeb1RSJU0YbABLBayLu12/Pxl0rQ8UBeuErd5SOcqzghoS0tpxZgsigLorslVZs NqVI6QpWgsPzYEkyifGNPEXyFxgDdZJeTd8eH+7mKQrQ5YWChhk4bqULhHney0U= =m9ej -----END PGP SIGNATURE----- --SfpnJSgHfndSHnDlLBhW4gPfPNjOFfORv--