From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52345) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJ1Ki-0005SP-4Y for qemu-devel@nongnu.org; Thu, 27 Feb 2014 08:49:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WJ1Kc-00036Y-Dt for qemu-devel@nongnu.org; Thu, 27 Feb 2014 08:49:03 -0500 Received: from s16892447.onlinehome-server.info ([82.165.15.123]:41185) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJ1Kc-00035a-1X for qemu-devel@nongnu.org; Thu, 27 Feb 2014 08:48:58 -0500 Message-ID: <530F41CC.7040008@ilande.co.uk> Date: Thu, 27 Feb 2014 13:46:52 +0000 From: Mark Cave-Ayland MIME-Version: 1.0 References: <20140225115043.GC12803@kentang.lan> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL] qemu-sparc: CG3 framebuffer plus misc sun4m fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Blue Swirl , QEMU Developers On 26/02/14 18:45, Peter Maydell wrote: > On 25 February 2014 11:50, Mark Cave-Ayland > wrote: >> Hi Peter, >> >> This branch contains updates for SPARC, particularly a new implementation of the CG3 framebuffer as >> reviewed on list, plus timer/hostid fixes from Olivier. Please pull. > > Hi. This fails to build on 32 bit, I'm afraid: > > /root/qemu/hw/display/cg3.c: In function 'cg3_reg_write': > /root/qemu/hw/display/cg3.c:202:5: error: format '%lx' expects > argument of type 'long unsigned int', but argument 2 has type > 'uint64_t' [-Werror=format] Ah I see. Looks like I accidentally used a direct format identifier rather than one of the standard format macros which is what caused the breakage on a different architecture. I've just updated my qemu-sparc branch with an updated version which uses HWADDR_PRIx for displaying addresses and PRIx64 for displaying the 64-bit value field for those 2 lines in question which should resolve it. >> http://github.com/mcayland/qemu.git qemu-sparc > > PS: if you could be consistent with the URL you use in pull > requests that would be nice; I have you recorded as https://... > (not a big deal, but it means my cut-n-paste "apply this" > doesn't work and I have to tweak it by hand.) Yes, my fault entirely. I sent pull request remotely in order to submit it before freeze and obviously made a typo. I'll resubmit a PULLv2 shortly which will have the correct URL. Many thanks, Mark.