From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJ5JE-0000uz-1e for qemu-devel@nongnu.org; Thu, 27 Feb 2014 13:03:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WJ5J9-0005dv-Eb for qemu-devel@nongnu.org; Thu, 27 Feb 2014 13:03:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:20972) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJ5J9-0005do-5G for qemu-devel@nongnu.org; Thu, 27 Feb 2014 13:03:43 -0500 Message-ID: <530F7DFA.1080703@redhat.com> Date: Thu, 27 Feb 2014 11:03:38 -0700 From: Eric Blake MIME-Version: 1.0 References: <1393499376-4374-1-git-send-email-wenchaoqemu@gmail.com> <1393499376-4374-4-git-send-email-wenchaoqemu@gmail.com> In-Reply-To: <1393499376-4374-4-git-send-email-wenchaoqemu@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="E908n4wdOSnWr0nsnMfEcfPn5q5hMIfKU" Subject: Re: [Qemu-devel] [PATCH V8 03/10] qapi script: remember line number in schema parsing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, kwolf@redhat.com, Wenchao Xia , armbru@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --E908n4wdOSnWr0nsnMfEcfPn5q5hMIfKU Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/27/2014 04:09 AM, Wenchao Xia wrote: > From: Wenchao Xia >=20 > Before this patch, 'QAPISchemaError' scans whole input until 'pos' > to get error line number. After this patch, the scan is avoided since > line number is remembered in schema parsing. This patch also benefits > other error report functions, which would be introduced later. >=20 > Signed-off-by: Wenchao Xia > Signed-off-by: Wenchao Xia Another double S-o-B. > --- > scripts/qapi.py | 14 ++++++++------ > 1 files changed, 8 insertions(+), 6 deletions(-) >=20 My python is not strong, this is a very weak: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --E908n4wdOSnWr0nsnMfEcfPn5q5hMIfKU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTD336AAoJEKeha0olJ0NqyG0IAJImsOOL0WlF3SGwnoclswRD sNg6Oe0hAkCFyUTqAMKcqxHQhoy+hxE87/2rBBPBYeBLoGiJKz///2G5nVoXlMr+ OH/zbKDFwTuHpGLhq+hRS23qNSvoS1ogmUmaCMqlB5uViKunmEKsjQCQiG0nxbW/ uTgSQGQrFZJtnVlfsh/xM+wJgnw2OmS4MHUSHNgsWqymf5sG07Rjoxhcr6VVHgtM o/HkZVNMoLJCVEukEhC+9nVTJag5fJtk7E2DDE8JYmlNvHZ9SeS/XNvY7X6D1DXR c5S9CrTzNXmfzifTy2fz7Lg50SqunFx8HxaOK8cVsaQUdrKjRTvJLsMSIeSpzdY= =iYks -----END PGP SIGNATURE----- --E908n4wdOSnWr0nsnMfEcfPn5q5hMIfKU--