From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39283) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJ7LF-0001dQ-LS for qemu-devel@nongnu.org; Thu, 27 Feb 2014 15:14:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WJ7LB-0003zP-CV for qemu-devel@nongnu.org; Thu, 27 Feb 2014 15:14:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:2081) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJ7LB-0003zG-2q for qemu-devel@nongnu.org; Thu, 27 Feb 2014 15:13:57 -0500 Message-ID: <530F9C43.50705@redhat.com> Date: Thu, 27 Feb 2014 13:12:51 -0700 From: Eric Blake MIME-Version: 1.0 References: <1393499376-4374-1-git-send-email-wenchaoqemu@gmail.com> <1393499376-4374-7-git-send-email-wenchaoqemu@gmail.com> In-Reply-To: <1393499376-4374-7-git-send-email-wenchaoqemu@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WF5PGbv2MbV5bH4nE83PsSUQkSNwk6Vgl" Subject: Re: [Qemu-devel] [PATCH V8 06/10] qapi script: use same function to generate enum string List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, kwolf@redhat.com, Wenchao Xia , armbru@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WF5PGbv2MbV5bH4nE83PsSUQkSNwk6Vgl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/27/2014 04:09 AM, Wenchao Xia wrote: > From: Wenchao Xia >=20 > Prior to this patch, qapi-visit.py used custom code to generate enum > names used for handling a qapi union. Fix it to instead reuse common > code, with identical generated results, and allowing future updates to > generation to only need to touch one place. >=20 > Signed-off-by: Wenchao Xia > Signed-off-by: Wenchao Xia > --- Double S-o-B here and in 5. > scripts/qapi-types.py | 6 +++--- > scripts/qapi-visit.py | 19 +++++++++++++------ > scripts/qapi.py | 13 +++++++++---- > 3 files changed, 25 insertions(+), 13 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --WF5PGbv2MbV5bH4nE83PsSUQkSNwk6Vgl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTD5xDAAoJEKeha0olJ0NqxX0H/j4D6prDk0i13UBRPYaShZnd GCgILweRPgyIEo1VmpWlGZhDXXpEX2UlGlaveSsJusFBIDvc2dl5pIrjciZ+tBLb lo25W21dPOAnVGC2WHOB2sNcmI/5XskJmTO9Us7M+68w4Ddr6drDwUgWmVhukak5 CQkCmTENE5CgZqd3XZOEt40ZRxrD2oitSmXtbFfJBS4bvzjeZzup4zPHa395Wb2f oI1GlAKTANlYjo/rRtyrHQq7ChTFbFwFY6dJjPXlp+kfxkkYvvpERVi+khPUd9gf ScmcWi1etPeaPTC0JDv74w7pIl1Gti6VyzR0UI4vDFrex1SPJlGfV/xsTqaKJ50= =QYnO -----END PGP SIGNATURE----- --WF5PGbv2MbV5bH4nE83PsSUQkSNwk6Vgl--