From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53805) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJ8K9-0001q6-Sk for qemu-devel@nongnu.org; Thu, 27 Feb 2014 16:17:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WJ8K5-0000QU-4S for qemu-devel@nongnu.org; Thu, 27 Feb 2014 16:16:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJ8K4-0000QJ-R8 for qemu-devel@nongnu.org; Thu, 27 Feb 2014 16:16:53 -0500 Message-ID: <530FAB40.8030106@redhat.com> Date: Thu, 27 Feb 2014 14:16:48 -0700 From: Eric Blake MIME-Version: 1.0 References: <20140211130013.12374.17471.stgit@fimbulvetr.bsc.es> <20140211130030.12374.67440.stgit@fimbulvetr.bsc.es> In-Reply-To: <20140211130030.12374.67440.stgit@fimbulvetr.bsc.es> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="w50WTD0mEw9nI9W2kkpSS95NM43Nfc0nX" Subject: Re: [Qemu-devel] [PATCH v3 3/3] qapi: Add tests for the "include" directive List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?TGx1w61zIFZpbGFub3Zh?= , qemu-devel@nongnu.org Cc: Markus Armbruster , Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --w50WTD0mEw9nI9W2kkpSS95NM43Nfc0nX Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/11/2014 06:00 AM, Llu=C3=ADs Vilanova wrote: > Signed-off-by: Llu=C3=ADs Vilanova > --- > +++ b/tests/Makefile > @@ -124,7 +124,8 @@ check-qapi-schema-y :=3D $(addprefix tests/qapi-sch= ema/, \ > missing-comma-object.json non-objects.json \ > qapi-schema-test.json quoted-structural-chars.json \ > trailing-comma-list.json trailing-comma-object.json \ > - unclosed-list.json unclosed-object.json unclosed-string.json) > + unclosed-list.json unclosed-object.json unclosed-string.json\ The other lines have a space before \, but that's cosmetic. This will conflict with Wenchao's series to add enum discriminators of unions, but that should be an obvious conflict resolution for whichever series goes in second. > +++ b/tests/qapi-schema/include-cycle.err > @@ -0,0 +1 @@ > +include-cycle.json:1:1: Inifite inclusion loop: include-cycle.json -> = include-cycle.json Once the typo in 2/3 is fixed, this needs fixing too. You tested a single-cycle file, but it might also be worth adding a circular chain (A includes B, B includes C, C includes A) to prove it also triggers the cycle-detection logic. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --w50WTD0mEw9nI9W2kkpSS95NM43Nfc0nX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTD6tBAAoJEKeha0olJ0Nqu+YH/1aN+jIzfXE33I5M1yiUjgwV eDkCRSIO28Av/qwCwfeFwvotHoqIr2QGQKr412Tmp5E9WorZrwTSgwoQFi8fmUPO FhHP3NtVRs0VKRDLpnTjH6WupqL/uFa/0OG1536oDey9NkiyzrlxhqlHwaVNH0FG sL0aQh8UlLgMnQJh2YWpj5taJkSNTEgtsMyrZAV6+jow/KpnAJ4qH7d9rLEnhJA+ 8lhaHIkRENeQpsUADDueGrq4f2p8PNVfiMdStf8ld/SKerND4LstRZ+47VJGj3+8 u7OvAMT4SP3UJG8VI1g8vD4/sDl47kxM85M8eTS9XAupmjllZKWq14V1fadbNaA= =5e+6 -----END PGP SIGNATURE----- --w50WTD0mEw9nI9W2kkpSS95NM43Nfc0nX--