From: Eric Blake <eblake@redhat.com>
To: "Luiz Capitulino" <lcapitulino@redhat.com>,
"Lluís Vilanova" <vilanova@ac.upc.edu>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/3] qapi: Allow modularization of QAPI schema files
Date: Thu, 27 Feb 2014 14:17:30 -0700 [thread overview]
Message-ID: <530FAB6A.8060400@redhat.com> (raw)
In-Reply-To: <20140227103148.49fdcc6c@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 812 bytes --]
On 02/27/2014 08:31 AM, Luiz Capitulino wrote:
> On Tue, 11 Feb 2014 14:00:14 +0100
> Lluís Vilanova <vilanova@ac.upc.edu> wrote:
>
>> Adds the "include(...)" primitive to the syntax of QAPI schema files, allowing
>> these to be modularized into multiple per-topic files in the future.
>
> Markus, Eric, you commented/reviewed v2 of this series. Any comments
> against v3?
A couple nits that still need fixing (see individual messages), but if
you feel comfortable fixing them now instead of waiting for a v4, then
go ahead and add:
Series: Reviewed-by: Eric Blake <eblake@redhat.com>
Then again, adding a cycle test for chained inclusion cycles in test 3
may be best with a v4.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-02-27 21:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 13:00 [Qemu-devel] [PATCH v3 0/3] qapi: Allow modularization of QAPI schema files Lluís Vilanova
2014-02-11 13:00 ` [Qemu-devel] [PATCH v3 1/3] qapi: Use an explicit input file Lluís Vilanova
2014-02-11 13:00 ` [Qemu-devel] [PATCH v3 2/3] qapi: Add a primitive to include other files from a QAPI schema file Lluís Vilanova
2014-02-27 21:14 ` Eric Blake
2014-02-11 13:00 ` [Qemu-devel] [PATCH v3 3/3] qapi: Add tests for the "include" directive Lluís Vilanova
2014-02-27 21:16 ` Eric Blake
2014-02-27 15:31 ` [Qemu-devel] [PATCH v3 0/3] qapi: Allow modularization of QAPI schema files Luiz Capitulino
2014-02-27 21:17 ` Eric Blake [this message]
2014-03-01 9:10 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530FAB6A.8060400@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).