From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54035) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJ8Kp-0002cb-3X for qemu-devel@nongnu.org; Thu, 27 Feb 2014 16:17:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WJ8Kk-0000fW-3k for qemu-devel@nongnu.org; Thu, 27 Feb 2014 16:17:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:3176) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJ8Kj-0000fO-Qm for qemu-devel@nongnu.org; Thu, 27 Feb 2014 16:17:34 -0500 Message-ID: <530FAB6A.8060400@redhat.com> Date: Thu, 27 Feb 2014 14:17:30 -0700 From: Eric Blake MIME-Version: 1.0 References: <20140211130013.12374.17471.stgit@fimbulvetr.bsc.es> <20140227103148.49fdcc6c@redhat.com> In-Reply-To: <20140227103148.49fdcc6c@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VekaweuRueivPUFolrsvM5rrgnLxVB528" Subject: Re: [Qemu-devel] [PATCH v3 0/3] qapi: Allow modularization of QAPI schema files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino , =?UTF-8?B?TGx1w61zIFZpbGFubw==?= =?UTF-8?B?dmE=?= Cc: qemu-devel@nongnu.org, Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VekaweuRueivPUFolrsvM5rrgnLxVB528 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/27/2014 08:31 AM, Luiz Capitulino wrote: > On Tue, 11 Feb 2014 14:00:14 +0100 > Llu=C3=ADs Vilanova wrote: >=20 >> Adds the "include(...)" primitive to the syntax of QAPI schema files, = allowing >> these to be modularized into multiple per-topic files in the future. >=20 > Markus, Eric, you commented/reviewed v2 of this series. Any comments > against v3? A couple nits that still need fixing (see individual messages), but if you feel comfortable fixing them now instead of waiting for a v4, then go ahead and add: Series: Reviewed-by: Eric Blake Then again, adding a cycle test for chained inclusion cycles in test 3 may be best with a v4. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --VekaweuRueivPUFolrsvM5rrgnLxVB528 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTD6tqAAoJEKeha0olJ0Nq6D4H/A86y4Yndq7H6DOR6up8uh/U wWpp8NHllwvQUrxo1938fkMfQSFz+f7kXG5IHxkXhtzYJfhNePZRT1kkaVcew9jT 8VGZpNJ9oHCc/KP9VB72CFdGMcN6A52jKkfoWHqyFxtYXMmR6dxdL5xuwyWFx46q a6LOpM0uwTvUFbb6hKBpMDyresJIMcoCjsb39+fgyMMsZzn7ED8GWRm3aEhwslb+ h6Y9Z8XR8Z8IEYR0qO45bmWJA754bZnyJZSm7fsRZsbwyD/W8cNYbsFSZDUea4hH H5OsRwQIFje5LQepNUXdjvvgIlIvYbmj8ZwzRQhQuqr9EKBaEBYYGoeEvuXeYFs= =qSHN -----END PGP SIGNATURE----- --VekaweuRueivPUFolrsvM5rrgnLxVB528--