From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56154) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJ8Uq-0006di-CY for qemu-devel@nongnu.org; Thu, 27 Feb 2014 16:28:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WJ8Ul-00047q-3h for qemu-devel@nongnu.org; Thu, 27 Feb 2014 16:28:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34081) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJ8Uk-00047k-RQ for qemu-devel@nongnu.org; Thu, 27 Feb 2014 16:27:55 -0500 Message-ID: <530FADD2.3080805@redhat.com> Date: Thu, 27 Feb 2014 14:27:46 -0700 From: Eric Blake MIME-Version: 1.0 References: <1393499376-4374-1-git-send-email-wenchaoqemu@gmail.com> <1393499376-4374-8-git-send-email-wenchaoqemu@gmail.com> In-Reply-To: <1393499376-4374-8-git-send-email-wenchaoqemu@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dDMkrGpMKkrf0HpqWiL06q0HRKuJBdr25" Subject: Re: [Qemu-devel] [PATCH V8 07/10] qapi script: support enum type as discriminator in union List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, kwolf@redhat.com, Wenchao Xia , armbru@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --dDMkrGpMKkrf0HpqWiL06q0HRKuJBdr25 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/27/2014 04:09 AM, Wenchao Xia wrote: > From: Wenchao Xia >=20 > By default, any union will automatically generate a enum type as > "[UnionName]Kind" in C code, and it is duplicated when the discriminato= r > is specified as a pre-defined enum type in schema. After this patch, > the pre-defined enum type will be really used as the switch case > condition in generated C code, if discriminator is an enum field. >=20 > Signed-off-by: Wenchao Xia > Signed-off-by: Wenchao Xia > --- Double S-o-B. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --dDMkrGpMKkrf0HpqWiL06q0HRKuJBdr25 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTD63SAAoJEKeha0olJ0Nq28kIAI4oXyXdMgWfraMecSt7iZCp 5sejmIpIXd53R1T1F1aAZ7JoR1DlkVrKSHjNJeqlwnxM4AIjsKg2VDBhx09G/mIU 17h1vwFBJS9C54hJmP+LSmE8zB6qR10v3UQLG7zJejj9q10B0MYNdL954OhBT3tW N5IMsj1NnvDxuGy2zM2yjSRE2gG7WStpDuduWFOzb0gbA3owPF4bsBk6nyQUby9X uLeeonFxNy3T48LOmB4ZQTwGDGqtZQE2FbGSDVYiRMBH+/ig3aDofEzKYDg/nTKr F6ewF6tna2EUtXmaCxRLIXMP4GstAYnEz9U9bW9njD7ZxP6Xs5kavrkTErqaKoQ= =ZneS -----END PGP SIGNATURE----- --dDMkrGpMKkrf0HpqWiL06q0HRKuJBdr25--