From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33758)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WJ8qr-0003o7-MG
	for qemu-devel@nongnu.org; Thu, 27 Feb 2014 16:50:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WJ8ql-0003cy-1J
	for qemu-devel@nongnu.org; Thu, 27 Feb 2014 16:50:45 -0500
Received: from mx1.redhat.com ([209.132.183.28]:14720)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WJ8qk-0003bs-P4
	for qemu-devel@nongnu.org; Thu, 27 Feb 2014 16:50:38 -0500
Message-ID: <530FB326.9080602@redhat.com>
Date: Thu, 27 Feb 2014 22:50:30 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <CAFEAcA8aEdntMxibVvTn7P3iZV=hFpWpSAqH=XQqwcu1yt1CYA@mail.gmail.com>
	<530F98A2.8040600@weilnetz.de>
In-Reply-To: <530F98A2.8040600@weilnetz.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] git build from clean broken?
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>, Peter Maydell <peter.maydell@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>
Cc: Fam Zheng <famz@redhat.com>

Il 27/02/2014 20:57, Stefan Weil ha scritto:
> Yes. I saw that problem, too. This patch for Makefile fixed it for me:
> 
> index ccab967,a28a3c8..8ec3a99
> @@@ -170,6 -159,6 +170,7 @@@ qemu-options.def: $(SRC_PATH)/qemu-opti
>   SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS))
>   SOFTMMU_SUBDIR_RULES=$(filter %-softmmu,$(SUBDIR_RULES))
> 
> ++$(SOFTMMU_SUBDIR_RULES): $(block-obj-y)
>   $(SOFTMMU_SUBDIR_RULES): config-all-devices.mak

This is correct.  Alternatively:

------------------ 8< --------------------
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: [PATCH] build: build block-obj-y explicitly before recursing

block-obj-y is not anymore part of common-obj-y, because "nesting"
variables is complicated and requires specifying the correct
ordering in the calls to unnest-vars.  However, because of this
we need to specify block-obj-y in the dependencies of the
target subdirectories.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

diff --git a/Makefile b/Makefile
index a443cd4..3938b6c 100644
--- a/Makefile
+++ b/Makefile
@@ -167,7 +167,7 @@ subdir-dtc:dtc/libfdt dtc/tests
 dtc/%:
 	mkdir -p $@
 
-$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y)
+$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y) $(block-obj-y)
 
 ROMSUBDIR_RULES=$(patsubst %,romsubdir-%, $(ROMS))
 romsubdir-%:
-- 
1.8.5.3

Paolo