From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34595) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJ8uO-00060m-1R for qemu-devel@nongnu.org; Thu, 27 Feb 2014 16:54:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WJ8uG-0004lV-PB for qemu-devel@nongnu.org; Thu, 27 Feb 2014 16:54:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:25007) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJ8uG-0004lE-Gn for qemu-devel@nongnu.org; Thu, 27 Feb 2014 16:54:16 -0500 Message-ID: <530FB404.5060606@redhat.com> Date: Thu, 27 Feb 2014 14:54:12 -0700 From: Eric Blake MIME-Version: 1.0 References: <1393499376-4374-1-git-send-email-wenchaoqemu@gmail.com> <1393499376-4374-9-git-send-email-wenchaoqemu@gmail.com> In-Reply-To: <1393499376-4374-9-git-send-email-wenchaoqemu@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="l8HHTOjmIHv9nDJAKudjP8hqD9Nmn2Bnr" Subject: Re: [Qemu-devel] [PATCH V8 08/10] qapi: convert BlockdevOptions to use enum discriminator List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, kwolf@redhat.com, Wenchao Xia , armbru@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --l8HHTOjmIHv9nDJAKudjP8hqD9Nmn2Bnr Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/27/2014 04:09 AM, Wenchao Xia wrote: > From: Wenchao Xia >=20 > After this patch, hidden enum type BlockdevOptionsKind will not > be generated, and other API can use enum BlockdevDriver. >=20 > Signed-off-by: Wenchao Xia > Signed-off-by: Wenchao Xia Double S-o-B. > --- > qapi-schema.json | 14 +++++++++++++- > 1 files changed, 13 insertions(+), 1 deletions(-) >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index fcb2280..7f587b4 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -4200,6 +4200,18 @@ > '*no-flush': 'bool' } } > =20 > ## > +# @BlockdevDriver > +# > +# Drivers that are supported in block device operations. > +# > +# Since: 2.0 > +## > +{ 'enum': 'BlockdevDriver', > + 'data': [ 'file', 'http', 'https', 'ftp', 'ftps', 'tftp', 'vvfat', '= blkdebug', > + 'blkverify', 'bochs', 'cloop', 'cow', 'dmg', 'parallels', = 'qcow', > + 'qcow2', 'qed', 'raw', 'vdi', 'vhdx', 'vmdk', 'vpc', 'quor= um' ] } I see you've picked up 'quorum' since last time :) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --l8HHTOjmIHv9nDJAKudjP8hqD9Nmn2Bnr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTD7QEAAoJEKeha0olJ0NqH20H/RDqoKoqANZlimvTWAFsq/06 qlhgp5k5DaYR3xdG34vsHaSQkHqesHGgI+veFQntzhUOeYQwsU5Ci/9r11tLvsqP ugIaL3P6uQk/4FdHcvw+sl2jsRB0KePZ5KdqMu2McY9VEERpqT4myM+w+uaoF8yi CoptagnyT7Mf6bj7mNFy8hBI187ONM8IdUctOLpSeZ+qOmmIx501b/ffu09NNVrd ck3Sdyd4/A9SRPYBnwS6520zPh6vv0hvXdkJOt6xcjvXjCbhp6gC7I81gcVYzL2b xRMGVfKEVCcXmDy2BLtp6Xyn+IMSh1SuH+xUUm3JMXFmkTLehFUEXvdKd5mlMTg= =ZouI -----END PGP SIGNATURE----- --l8HHTOjmIHv9nDJAKudjP8hqD9Nmn2Bnr--