From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJ94u-0001md-I8 for qemu-devel@nongnu.org; Thu, 27 Feb 2014 17:05:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WJ94p-0008Ri-M0 for qemu-devel@nongnu.org; Thu, 27 Feb 2014 17:05:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44124) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJ94p-0008Rd-Cm for qemu-devel@nongnu.org; Thu, 27 Feb 2014 17:05:11 -0500 Message-ID: <530FB691.6050907@redhat.com> Date: Thu, 27 Feb 2014 15:05:05 -0700 From: Eric Blake MIME-Version: 1.0 References: <1393499376-4374-1-git-send-email-wenchaoqemu@gmail.com> <1393499376-4374-10-git-send-email-wenchaoqemu@gmail.com> In-Reply-To: <1393499376-4374-10-git-send-email-wenchaoqemu@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9d0XmSnG5tlkM6J3J0PKToxqV7lqg1Slf" Subject: Re: [Qemu-devel] [PATCH V8 09/10] qapi script: do not allow string discriminator List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, kwolf@redhat.com, Wenchao Xia , armbru@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9d0XmSnG5tlkM6J3J0PKToxqV7lqg1Slf Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/27/2014 04:09 AM, Wenchao Xia wrote: > From: Wenchao Xia >=20 > Signed-off-by: Wenchao Xia > Signed-off-by: Wenchao Xia Double S-o-B. The commit message is a bit sparse; the one-line summary mentions what, but for a change like this where you are taking away functionality, it's also good to mention WHY (hint: enum-based discriminators provide better type-safety and ensure that future qapi additions do not forget to adjust dependent unions). > --- > docs/qapi-code-gen.txt | 5 +---- Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --9d0XmSnG5tlkM6J3J0PKToxqV7lqg1Slf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTD7aRAAoJEKeha0olJ0NqOm0H/iRroXJCSox8k9cTnr8qij9P bpUZsqralBCNPkFdP2c8Wf/oN0qIquXWYtcOELDkaPDwKCukrbYahz/mxDqyw2vx 8DiwcvELIkQph/erebTPSc78y3oZDuTynQ+S3iYHJhinMzEgU619c2zBr8yiyFMA 3wwBwM7Rzr1n14WEyKElailogK2DaSF9+vWmGkRm1EXdN/Udkh1fGmQ2APdRwU1D O22UuCnNhrumKZIbCA6yIxzx1qkaOfKaYJhc3FtwL46RPAuJTSIP9gS6obMKPcIn h0En5qGkpeDZKWAjWINECTJDbVge0yAZF5B6ObuHYPfiIvHRnhbstkYtWdkvwTc= =ec4b -----END PGP SIGNATURE----- --9d0XmSnG5tlkM6J3J0PKToxqV7lqg1Slf--