From: Joaquim Barrera <jbarrera@ac.upc.edu>
To: Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@gmail.com>
Cc: Libvirt Users <libvirt-users@redhat.com>,
Michal Privoznik <mprivozn@redhat.com>,
Jeff Cody <jcody@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [libvirt-users] Adjust disk image migration (NBD)
Date: Fri, 28 Feb 2014 11:41:49 +0100 [thread overview]
Message-ID: <531067ED.7000404@ac.upc.edu> (raw)
In-Reply-To: <392369891.8578031.1393280788249.JavaMail.zimbra@redhat.com>
On 24/02/14 23:26, Paolo Bonzini wrote:
>> Thanks for raising this.
>>
>> I noticed that mirror_run() does not throttle the first loop where it
>> populates the dirty bitmap using bdrv_is_allocated_above().
> This is on purpose. Does it causes a noticeable stall in the guest?
>
>> The main
>> copy loop does take the speed limit into account but perhaps that's
>> broken too.
> Yeah, it looks broken. Each iteration of the loop can write much more
> than sectors_per_chunk sectors, but here:
>
> if (s->common.speed) {
> delay_ns = ratelimit_calculate_delay(&s->limit, sectors_per_chunk);
> } else {
> delay_ns = 0;
> }
>
> the second argument is fixed. :/
>
> Paolo
>
Thanks for the answer. Something is still not clear to me. Are we in
front of a bug (that means, something that could be fixed) or is this
behaviour somehow expected for some reason? More and more tests I am
doing, I get allways the same throughput chart: unlimited bandwidth when
syncronizing the disk, and smooth bandwidth limit when migrating RAM.
Joaquim
next prev parent reply other threads:[~2014-02-28 10:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <52FDE495.4050004@ac.upc.edu>
2014-02-14 10:58 ` [Qemu-devel] [libvirt-users] Adjust disk image migration (NBD) Michal Privoznik
2014-02-24 15:16 ` Stefan Hajnoczi
2014-02-24 22:26 ` Paolo Bonzini
2014-02-28 10:41 ` Joaquim Barrera [this message]
2014-02-28 10:43 ` Paolo Bonzini
2014-03-11 17:13 ` Joaquim Barrera
2014-03-20 8:06 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531067ED.7000404@ac.upc.edu \
--to=jbarrera@ac.upc.edu \
--cc=jcody@redhat.com \
--cc=libvirt-users@redhat.com \
--cc=mprivozn@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).