From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Weil <sw@weilnetz.de>, Jeff Cody <jcody@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] build: build block-obj-y explicitly before recursing
Date: Fri, 28 Feb 2014 11:45:06 +0100 [thread overview]
Message-ID: <531068B2.4000900@redhat.com> (raw)
In-Reply-To: <53101E5A.3040903@weilnetz.de>
Il 28/02/2014 06:27, Stefan Weil ha scritto:
>>> >> -$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y)
>>> >> +$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y) $(block-obj-y)
> Using SUBDIR_RULES here instead of SOFTMMU_SUBDIR_RULES (as in my patch)
> includes more dependencies: $(block-obj-y) will also be built for the
> user emulation code (i386-linux-user, ...) which does not need it. As
> far as I see, SOFTMMU_SUBDIR_RULES is sufficient.
True, it's just ugly to have all the dependencies in different parts of
the Makefile.
If you fix it, can you move this line close to the existing
$(SOFTMMU_SUBDIR_RULES): config-all-devices.mak
We have too many knobs. :(
Paolo
prev parent reply other threads:[~2014-02-28 10:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 22:22 [Qemu-devel] [PATCH] build: build block-obj-y explicitly before recursing Paolo Bonzini
2014-02-27 22:50 ` Jeff Cody
2014-02-28 5:27 ` Stefan Weil
2014-02-28 5:49 ` Stefan Weil
2014-02-28 10:45 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531068B2.4000900@redhat.com \
--to=pbonzini@redhat.com \
--cc=jcody@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).