From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38314)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WJKwT-0005I6-8c
	for qemu-devel@nongnu.org; Fri, 28 Feb 2014 05:45:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WJKwM-0003gS-UY
	for qemu-devel@nongnu.org; Fri, 28 Feb 2014 05:45:21 -0500
Received: from mx1.redhat.com ([209.132.183.28]:35361)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WJKwM-0003gJ-Lu
	for qemu-devel@nongnu.org; Fri, 28 Feb 2014 05:45:14 -0500
Message-ID: <531068B2.4000900@redhat.com>
Date: Fri, 28 Feb 2014 11:45:06 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1393539728-27389-1-git-send-email-pbonzini@redhat.com>
	<20140227225023.GF4165@localhost.localdomain>
	<53101E5A.3040903@weilnetz.de>
In-Reply-To: <53101E5A.3040903@weilnetz.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] build: build block-obj-y explicitly before
 recursing
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>, Jeff Cody <jcody@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org

Il 28/02/2014 06:27, Stefan Weil ha scritto:
>>> >> -$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y)
>>> >> +$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y) $(block-obj-y)
> Using SUBDIR_RULES here instead of SOFTMMU_SUBDIR_RULES (as in my patch)
> includes more dependencies: $(block-obj-y) will also be built for the
> user emulation code (i386-linux-user, ...) which does not need it. As
> far as I see, SOFTMMU_SUBDIR_RULES is sufficient.

True, it's just ugly to have all the dependencies in different parts of 
the Makefile.

If you fix it, can you move this line close to the existing

$(SOFTMMU_SUBDIR_RULES): config-all-devices.mak

We have too many knobs. :(

Paolo