From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37326) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJNE5-0005bH-In for qemu-devel@nongnu.org; Fri, 28 Feb 2014 08:11:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WJNE1-0002MX-83 for qemu-devel@nongnu.org; Fri, 28 Feb 2014 08:11:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44009) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJNE0-0002MR-Ul for qemu-devel@nongnu.org; Fri, 28 Feb 2014 08:11:37 -0500 Message-ID: <53108AF8.8020602@redhat.com> Date: Fri, 28 Feb 2014 06:11:20 -0700 From: Eric Blake MIME-Version: 1.0 References: <33183CC9F5247A488A2544077AF19020815D2278@SZXEMA503-MBS.china.huawei.com> In-Reply-To: <33183CC9F5247A488A2544077AF19020815D2278@SZXEMA503-MBS.china.huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eBU0msQDAmRfsu1GpR8xCe6oCjap6AOmv" Subject: Re: [Qemu-devel] [PATCH 2/7] migration: Add counters of updating the dirty bitmap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gonglei (Arei)" , "qemu-devel@nongnu.org" Cc: Peter Maydell , Juan Quintela , "pl@kamp.de" , "owasserm@redhat.com" , "aliguori@amazon.com" , "chenliang (T)" , "pbonzini@redhat.com" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --eBU0msQDAmRfsu1GpR8xCe6oCjap6AOmv Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/27/2014 09:08 PM, Gonglei (Arei) wrote: > Add counters to log the times of updating the dirty bitmap. >=20 > Signed-off-by: ChenLiang > Signed-off-by: Gonglei > --- > arch_init.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) Is it also worth updating MigrationStats in qapi-schema.json to expose these counts to the end user, to help benchmarking decide how often your optimizations hit for a given workload? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --eBU0msQDAmRfsu1GpR8xCe6oCjap6AOmv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTEIr5AAoJEKeha0olJ0NqJiQH/0c4JG/4ZvXgTkjRAYYoE7T4 RQb9BlFAnYI7jREa/QR6CBnBHhQENj97q9gfo3ZTTJmFjjJbDtn5z7bYx5zIU/bC wBwdTfEkqNEQyjn3RE3HkgW4Jkrnu2Bxaq6X4xn4r8Lf6Rcdbx5h0cVEBnrUf2KK TmEBPtxJ3kbCXzvWVjsaF3eImHO/tbFRF5jy3E29GarWntZdItmIDWXO7drYRTD2 LGamNsckVvJUuld3G+MhiBajosNGKhggTtJwuFCwV3ZY2WMgOCCGMbupMlmkbo4l ED3XcYIomzuA7VSBEHPkEzm60MIq0RyX/RTemlI37OPNJWSLOB7jsqWmrg0zss4= =9Ibv -----END PGP SIGNATURE----- --eBU0msQDAmRfsu1GpR8xCe6oCjap6AOmv--