From: Eric Blake <eblake@redhat.com>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Juan Quintela <quintela@redhat.com>, "pl@kamp.de" <pl@kamp.de>,
"owasserm@redhat.com" <owasserm@redhat.com>,
"aliguori@amazon.com" <aliguori@amazon.com>,
"chenliang (T)" <chenliang88@huawei.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/7] XBZRLE: rebuild the cache_is_cached function
Date: Fri, 28 Feb 2014 06:13:46 -0700 [thread overview]
Message-ID: <53108B8A.5040701@redhat.com> (raw)
In-Reply-To: <33183CC9F5247A488A2544077AF19020815D228D@SZXEMA503-MBS.china.huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]
On 02/27/2014 09:10 PM, Gonglei (Arei) wrote:
> Rebuild the cache_is_cached function.
>
> Signed-off-by: ChenLiang <chenliang88@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> page_cache.c | 33 +++++++++++++++------------------
> 1 file changed, 15 insertions(+), 18 deletions(-)
>
> diff --git a/page_cache.c b/page_cache.c
> index fa58ab2..34ec933 100644
> --- a/page_cache.c
> +++ b/page_cache.c
> @@ -121,24 +121,6 @@ static size_t cache_get_cache_pos(const PageCache *cache,
> return pos;
> }
>
> -bool cache_is_cached(const PageCache *cache, uint64_t addr,
> - uint64_t current_age)
Indentation was off pre-patch...
>
> +bool cache_is_cached(const PageCache *cache, uint64_t addr,
> + uint64_t current_age)
...but you should take the opportunity to fix it here.
bool cache_is_cached(const PageCache *cache, uint64_t addr,
uint64_t current_age)
> + if (it->it_addr == addr) {
> + /* updata the it_age when the cache hit */
s/updata/update/
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2014-02-28 13:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 4:10 [Qemu-devel] [PATCH 4/7] XBZRLE: rebuild the cache_is_cached function Gonglei (Arei)
2014-02-28 9:56 ` Dr. David Alan Gilbert
2014-02-28 13:13 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53108B8A.5040701@redhat.com \
--to=eblake@redhat.com \
--cc=aliguori@amazon.com \
--cc=arei.gonglei@huawei.com \
--cc=chenliang88@huawei.com \
--cc=owasserm@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).