From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47665) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJNwY-0003Ul-AE for Qemu-devel@nongnu.org; Fri, 28 Feb 2014 08:57:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WJNwT-0000kQ-M7 for Qemu-devel@nongnu.org; Fri, 28 Feb 2014 08:57:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51479) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJNwT-0000kL-Dp for Qemu-devel@nongnu.org; Fri, 28 Feb 2014 08:57:33 -0500 Message-ID: <531095C7.3020500@redhat.com> Date: Fri, 28 Feb 2014 06:57:27 -0700 From: Eric Blake MIME-Version: 1.0 References: <5310489A.4060501@cisco.com> <531091CB.9050908@redhat.com> <531094A1.8000400@cisco.com> In-Reply-To: <531094A1.8000400@cisco.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jbhRusvvWct2mIE5jB07VxVRIQivvFfck" Subject: Re: [Qemu-devel] Contribution - L2TPv3 transport List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Anton Ivanov (antivano)" Cc: "Qemu-devel@nongnu.org" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jbhRusvvWct2mIE5jB07VxVRIQivvFfck Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/28/2014 06:52 AM, Anton Ivanov (antivano) wrote: > On 28/02/14 13:40, Eric Blake wrote: >> On 02/28/2014 01:28 AM, Anton Ivanov (antivano) wrote: >>> Hi all, >>> >>> On behalf of Cisco Systems I am authorized to contribute a new transp= ort >>> to the network subsystem in qemu. >>> >>> +# >>> +# >>> +# Since 1.0 >> s/1.0/2.0/ >=20 > OK - just to clarify, which version is this referring to - qemu, api, e= tc? This field is the version of qemu that first contains the release. If your patch is on time to make the qemu 2.0 release, then 2.0 is appropriate; but we're close to feature freeze so it may end up being 2.1= =2E >=20 >> >>> +## >>> +## >>> +{ 'type': 'NetdevL2TPv3Options', >>> + 'data': { >>> + '*fd': 'str', >>> + '*src': 'str',=20 >> You didn't list 'src' as optional above. >=20 > That is intended. It is not optional for the ip command in Linux either= =2E > For L2TPv3 tunnels you have to specify the source address. But listing it as '*src' means it is optional. If it is mandatory, list it as 'src'. >=20 >> >> Trailing whitespace - run your submission through checkpatch.pl. >> >>> + '*dst': 'str',=20 >>> + '*mode': 'str',=20 >> As mentioned above, 'mode' should not be a string. >> >>> + '*txcookie': 'str', >>> + '*rxcookie': 'str', >>> + '*txsession': 'str', >>> + '*rxsession': 'str' >> These should probably be 'int', not 'str'. If you have to hand-parse = a >> string into a numeric value, you encoded the QMP wrong. >=20 > These by spec are either 32 bit or 64 bit integers. I will fix them > accordingly. The qapi type 'int' is 64-bit. You can further range check the values in your C code and fail the command if the user passed values that don't fit in 32 bits when they requested a 32-bit mode. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --jbhRusvvWct2mIE5jB07VxVRIQivvFfck Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTEJXHAAoJEKeha0olJ0NqTZQIAI0mltE8efhnwihRktw19+5d dMaaTvXsJfA2ZGDbt1bsRPAVkbbWbdv7AKAzxfFNOR56Gssp3d9qD5Dt5BEEu0qp rsjYTR7qik/MgLcdjJxR3gzTfBH95QtdybYe30ehSowloQ7WZJeCO+MM4hj6HUQs avSQL9XP6KXQyjB+qPXVsO0uqDSwnIf7dgGb1kThaJvsNNgmqxH3+2K1o7amhlMj 3mBKdQn4COQp+VbzqX8QKCZ0BikaUmX6cAPCfr3JY6yvDKz+tAiGWBLGgiaSjI9r IIBcTS5FGci/SamAvgw8xDLDgpB5uXk4WxczgwDWQpycm2ZT+ppDXFd6nssuW8Y= =nOEa -----END PGP SIGNATURE----- --jbhRusvvWct2mIE5jB07VxVRIQivvFfck--