From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38295) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJPF5-0005S4-LG for Qemu-devel@nongnu.org; Fri, 28 Feb 2014 10:20:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WJPEz-0004wT-8y for Qemu-devel@nongnu.org; Fri, 28 Feb 2014 10:20:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:23534) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJPEy-0004wI-N9 for Qemu-devel@nongnu.org; Fri, 28 Feb 2014 10:20:45 -0500 Message-ID: <5310A948.3060301@redhat.com> Date: Fri, 28 Feb 2014 16:20:40 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <5310489A.4060501@cisco.com> <531091CB.9050908@redhat.com> <53109683.1080907@redhat.com> <5310A5DE.9020805@redhat.com> In-Reply-To: <5310A5DE.9020805@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Contribution - L2TPv3 transport List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , "Anton Ivanov (antivano)" , "Qemu-devel@nongnu.org" Il 28/02/2014 16:06, Eric Blake ha scritto: > On 02/28/2014 07:00 AM, Paolo Bonzini wrote: >> Il 28/02/2014 14:40, Eric Blake ha scritto: >>> These should probably be 'int', not 'str'. If you have to hand-parse a >>> string into a numeric value, you encoded the QMP wrong. >> >> Eric, note that this is not QMP. It is only used for option parsing. > > But still, shouldn't option parsing be able to take advantage of > non-'str' typing to ease the task of handling numeric parameters? Indeed, and I pointed this out in my review as well. But the tradeoffs are a bit different, as you have already found out in the past. Paolo