From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40600)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WJPOY-00052x-35
	for qemu-devel@nongnu.org; Fri, 28 Feb 2014 10:30:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WJPOR-0008Tb-TZ
	for qemu-devel@nongnu.org; Fri, 28 Feb 2014 10:30:38 -0500
Received: from cantor2.suse.de ([195.135.220.15]:55032 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WJPOR-0008TR-MT
	for qemu-devel@nongnu.org; Fri, 28 Feb 2014 10:30:31 -0500
Message-ID: <5310AB93.8000208@suse.de>
Date: Fri, 28 Feb 2014 16:30:27 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1393597532-17078-1-git-send-email-petar.jovanovic@rt-rk.com>
In-Reply-To: <1393597532-17078-1-git-send-email-petar.jovanovic@rt-rk.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] linux-user: correct handling of break
 exception for MIPS
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Petar Jovanovic <petar.jovanovic@rt-rk.com>, qemu-devel@nongnu.org
Cc: riku.voipio@linaro.org, petar.jovanovic@imgtec.com, aurelien@aurel32.net

Hi,

Am 28.02.2014 15:25, schrieb Petar Jovanovic:
> From: Petar Jovanovic <petar.jovanovic@imgtec.com>
>=20
> Exception with break instruction has not been correctly propagated as
> SIGTRAP. This resolves crash issues with examples that use break
> instruction on MIPS.
>=20
> Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>
> ---
>  linux-user/main.c |    4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/linux-user/main.c b/linux-user/main.c
> index 9192977..c19e7fb 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -2384,6 +2384,10 @@ static int do_break(CPUMIPSState *env, target_si=
ginfo_t *info,
>          ret =3D 0;
>          break;
>      default:
> +        info->si_signo =3D TARGET_SIGTRAP;
> +        info->si_errno =3D 0;
> +        queue_signal(env, info->si_signo, &*info);

This looks strange. Isn't &*info =3D=3D info?

Other than that seems to touch only MIPS code and looks sensible.

Regards,
Andreas

> +        ret =3D 0;
>          break;
>      }
> =20

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg