From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJQQ4-0006PL-EN for qemu-devel@nongnu.org; Fri, 28 Feb 2014 11:36:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WJQPy-0005DL-EA for qemu-devel@nongnu.org; Fri, 28 Feb 2014 11:36:16 -0500 Message-ID: <5310BAE7.3080000@redhat.com> Date: Fri, 28 Feb 2014 17:35:51 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1392904246-15575-1-git-send-email-aik@ozlabs.ru> <1392904246-15575-4-git-send-email-aik@ozlabs.ru> <530609F9.1060105@redhat.com> <530F14C2.2050808@suse.de> <530F1670.2070701@redhat.com> <1393511950.31381.34.camel@localhost.localdomain> <530F52C5.3080209@redhat.com> <1393513484.31381.36.camel@localhost.localdomain> <5310A55B.7030602@ozlabs.ru> <5310A5BF.6030003@redhat.com> <5310A670.70304@ozlabs.ru> <5310B1E7.7090600@suse.de> In-Reply-To: <5310B1E7.7090600@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v5 3/6] vl: allow customizing the class of /machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Alexey Kardashevskiy Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, Alexander Graf , Marcel Apfelbaum Il 28/02/2014 16:57, Andreas F=C3=A4rber ha scritto: > Am 28.02.2014 16:08, schrieb Alexey Kardashevskiy: >> On 03/01/2014 02:05 AM, Paolo Bonzini wrote: >>> Il 28/02/2014 16:03, Alexey Kardashevskiy ha scritto: >>>> On 02/28/2014 02:04 AM, Marcel Apfelbaum wrote: >>>>> On Thu, 2014-02-27 at 15:59 +0100, Paolo Bonzini wrote: >>>>>> Il 27/02/2014 15:39, Marcel Apfelbaum ha scritto: >>>>>>>>> >>>>>>>>> Each of them highlights one of the two aspects that, in my opin= ion, >>>>>>>>> make >>>>>>>>> QOM interesting (respectively, unification of interfaces and th= e >>>>>>>>> containment tree). >>>>>>> I was planning to tackle the replacement of the machine from a co= ntainer >>>>>>> to an actual object too, however this patch conflicts with my >>>>>>> series because I already have a QOM Machine object created *alway= s* >>>>>>> and this patch adds another object *sometimes*. >>>>>>> >>>>>>> Is this patch's functionality in use yet? Any idea how to merge t= hose >>>>>>> ideas? >>>>>> >>>>>> pseries simply wants to make /machine implement the FWPathProvider >>>>>> interface. As long as you have a way for boards to specify a Type= Info >>>>>> for /machine, this patch will not get in the way. >>>>> Thanks Paolo! I'll be aware not to brake this functionality. >>>>> Marcel >>>> >>>> What is the outcome of this discussion for the patches I posted? Do = I have >>>> to wait till you finish that machine properties rework and repost or= ...? >>> >>> Your patches are fine. > > I disputed that in this case and asked for a code change in qdev code > either not creating the container and/or asserting that that code path > is not hit. You're right. The outcome of the discussion was not that the patches=20 are fine, but rather that they need not be blocked by Marcel's work. I=20 was too terse/vague/wrong---sorry. >>> Who gets in first, wins. The other, rebases. :) > > Negative, qemu.git is not a tombola. If there's known issues they need > to be fixed before merging. But yes, when there's two "good" approaches > then it's a matter of merge order, which ideally should involve > communication rather than competition among maintainers. Because the > pull that does not apply then gets bounced by Peter. Right, hence the smiley. People that submit patches should be aware of=20 conflicting series and tell the maintainers about it. Paolo