From: "Andreas Färber" <afaerber@suse.de>
To: Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <famz@redhat.com>,
Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v5 5/7] qdev: make get_pointer() handle temporary strings
Date: Fri, 28 Feb 2014 17:49:09 +0100 [thread overview]
Message-ID: <5310BE05.2060002@suse.de> (raw)
In-Reply-To: <1393600696-24118-6-git-send-email-stefanha@redhat.com>
Am 28.02.2014 16:18, schrieb Stefan Hajnoczi:
> From: Igor Mammedov <imammedo@redhat.com>
>
> get_pointer()'s print() callback might return a heap allocated
> string, to avoid adding dedicated get_pointer_foo for this case
> convert current print() callbacks to return temporary heap
> allocated string and make get_pointer() free it.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> hw/core/qdev-properties-system.c | 19 +++++++++++--------
> 1 file changed, 11 insertions(+), 8 deletions(-)
Not aware of the history of this patch (not CC'ed?) but looks okay,
Reviewed-by: Andreas Färber <afaerber@suse.de>
Do we have any users outside of this series?
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2014-02-28 16:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 15:18 [Qemu-devel] [PATCH v5 0/7] dataplane: switch to N:M devices-per-thread model Stefan Hajnoczi
2014-02-28 15:18 ` [Qemu-devel] [PATCH v5 1/7] object: add object_get_canonical_basename() Stefan Hajnoczi
2014-02-28 17:15 ` Andreas Färber
2014-02-28 18:27 ` Igor Mammedov
2014-03-03 9:52 ` Stefan Hajnoczi
2014-02-28 15:18 ` [Qemu-devel] [PATCH v5 2/7] rfifolock: add recursive FIFO lock Stefan Hajnoczi
2014-02-28 15:18 ` [Qemu-devel] [PATCH v5 3/7] aio: add aio_context_acquire() and aio_context_release() Stefan Hajnoczi
2014-02-28 15:18 ` [Qemu-devel] [PATCH v5 4/7] iothread: add I/O thread object Stefan Hajnoczi
2014-02-28 15:18 ` [Qemu-devel] [PATCH v5 5/7] qdev: make get_pointer() handle temporary strings Stefan Hajnoczi
2014-02-28 16:49 ` Andreas Färber [this message]
2014-03-03 9:41 ` Stefan Hajnoczi
2014-03-03 12:43 ` Igor Mammedov
2014-02-28 15:18 ` [Qemu-devel] [PATCH v5 6/7] iothread: add "iothread" qdev property type Stefan Hajnoczi
2014-02-28 15:18 ` [Qemu-devel] [PATCH v5 7/7] dataplane: replace internal thread with IOThread Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5310BE05.2060002@suse.de \
--to=afaerber@suse.de \
--cc=famz@redhat.com \
--cc=imammedo@redhat.com \
--cc=kwolf@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).