From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Andreas Färber" <andreas.faerber@web.de>,
"Markus Armbruster" <armbru@redhat.com>,
patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] configure: Always build with -fno-common
Date: Fri, 28 Feb 2014 09:19:36 -0800 [thread overview]
Message-ID: <5310C528.9010205@twiddle.net> (raw)
In-Reply-To: <1393451610-24617-1-git-send-email-peter.maydell@linaro.org>
On 02/26/2014 01:53 PM, Peter Maydell wrote:
> In QEMU we don't make any use at all of the common symbol
> functionality, so we can avoid this problem entirely simply
> by compiling with -fno-common. Enable this option for all
> builds, not just MacOSX, so that if we ever inadvertently
> introduce multiple definitions of some variable that will
> be immediately spotted as a build error rather than only
> breaking the MacOSX build.
>
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
next prev parent reply other threads:[~2014-02-28 17:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 21:53 [Qemu-devel] [PATCH] configure: Always build with -fno-common Peter Maydell
2014-02-28 17:19 ` Richard Henderson [this message]
2014-03-06 21:42 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5310C528.9010205@twiddle.net \
--to=rth@twiddle.net \
--cc=andreas.faerber@web.de \
--cc=armbru@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).