From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJR6G-0001ja-7D for qemu-devel@nongnu.org; Fri, 28 Feb 2014 12:19:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WJR6B-0004fE-HK for qemu-devel@nongnu.org; Fri, 28 Feb 2014 12:19:52 -0500 Received: from mail-qc0-x22d.google.com ([2607:f8b0:400d:c01::22d]:34877) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJR6B-0004es-C8 for qemu-devel@nongnu.org; Fri, 28 Feb 2014 12:19:47 -0500 Received: by mail-qc0-f173.google.com with SMTP id x3so1071630qcv.32 for ; Fri, 28 Feb 2014 09:19:46 -0800 (PST) Sender: Richard Henderson Message-ID: <5310C528.9010205@twiddle.net> Date: Fri, 28 Feb 2014 09:19:36 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1393451610-24617-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1393451610-24617-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] configure: Always build with -fno-common List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: =?ISO-8859-1?Q?Andreas_F=E4rber?= , Markus Armbruster , patches@linaro.org On 02/26/2014 01:53 PM, Peter Maydell wrote: > In QEMU we don't make any use at all of the common symbol > functionality, so we can avoid this problem entirely simply > by compiling with -fno-common. Enable this option for all > builds, not just MacOSX, so that if we ever inadvertently > introduce multiple definitions of some variable that will > be immediately spotted as a build error rather than only > breaking the MacOSX build. > > Suggested-by: Markus Armbruster > Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson r~