From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38763)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WJRNr-0006Bq-Ld
	for qemu-devel@nongnu.org; Fri, 28 Feb 2014 12:38:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WJRNj-00035l-9h
	for qemu-devel@nongnu.org; Fri, 28 Feb 2014 12:38:03 -0500
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5310C96E.8040002@twiddle.net>
Date: Fri, 28 Feb 2014 09:37:50 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1393455099-4831-1-git-send-email-tlfalcon@linux.vnet.ibm.com>
In-Reply-To: <1393455099-4831-1-git-send-email-tlfalcon@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4] target-ppc: gdbstub allow byte swapping
 for reading/writing registers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, agraf@suse.de

On 02/26/2014 02:51 PM, Thomas Falcon wrote:
> +void ppc_cpu_gdb_swap_register(uint8_t *mem_buf, int n)
> +{
> +    int len = ppc_cpu_gdb_register_len(n);
> +    int i = 0;
> +    uint8_t tmp;
> +    for (i = 0; i < len/2; i++) {
> +        tmp = *(mem_buf + i);
> +        *(mem_buf+i) = *(mem_buf + len - 1 - i);
> +        *(mem_buf + len - 1 - i) = tmp;
> +    }
> +}

Ew.

The number of register sizes you need to handle is extremely limited.  One can
easily use bswap32 and bswap64 for this.


r~