From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40339)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WJTjQ-0003lj-Rh
	for qemu-devel@nongnu.org; Fri, 28 Feb 2014 15:08:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WJTjI-0001xJ-Ec
	for qemu-devel@nongnu.org; Fri, 28 Feb 2014 15:08:28 -0500
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5310ECB0.6050704@twiddle.net>
Date: Fri, 28 Feb 2014 12:08:16 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1393455099-4831-1-git-send-email-tlfalcon@linux.vnet.ibm.com>
	<5310C96E.8040002@twiddle.net>
	<5310E343.1050005@linux.vnet.ibm.com>
In-Reply-To: <5310E343.1050005@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH v4] target-ppc: gdbstub allow
 byte swapping for reading/writing registers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org

On 02/28/2014 11:28 AM, Thomas Falcon wrote:
> How about this instead?
> 
> int len = ppc_cpu_gdb_register_len(n);
> if (len==4) {
>     bswap32s((uint32_t *)mem_buf);
> } else {
>     bswap64s((uint64_t *)mem_buf);
> }

Looks much better, thanks.


r~