From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56251)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WJV2v-0002gu-Hk
	for qemu-devel@nongnu.org; Fri, 28 Feb 2014 16:32:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WJV2p-0003h0-0C
	for qemu-devel@nongnu.org; Fri, 28 Feb 2014 16:32:41 -0500
Received: from mail-qc0-x22a.google.com ([2607:f8b0:400d:c01::22a]:38096)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WJV2o-0003gv-R0
	for qemu-devel@nongnu.org; Fri, 28 Feb 2014 16:32:34 -0500
Received: by mail-qc0-f170.google.com with SMTP id c9so1467993qcz.29
	for <qemu-devel@nongnu.org>; Fri, 28 Feb 2014 13:32:34 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5311006C.40003@twiddle.net>
Date: Fri, 28 Feb 2014 13:32:28 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1393618913-12411-1-git-send-email-ehabkost@redhat.com>
In-Reply-To: <1393618913-12411-1-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [qom-cpu PATCH 00/10] target-i386: Support
 check/enforce flags in TCG mode, too
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: Igor Mammedov <imammedo@redhat.com>, Aurelien Jarno <aurelien@aurel32.net>, Paolo Bonzini <pbonzini@redhat.com>

On 02/28/2014 12:21 PM, Eduardo Habkost wrote:
> This removes some duplication in the CPU feature checking and filtering code in
> cpu.c, and as a nice side-effect, will make the "check" and "enforce" flags work
> in TCG mode too.
> 
> Eduardo Habkost (10):
>   target-i386: Simplify reporting of unavailable features
>   target-i386: Merge feature filtering/checking functions
>   target-i386: Pass FeatureWord argument to
>     report_unavailable_features()
>   target-i386: Isolate KVM-specific code on CPU feature filtering logic
>   target-i386: Make TCG feature filtering more readable
>   target-i386: Filter FEAT_7_0_EBX TCG features too
>   target-i386: Filter KVM and 0xC0000001 features on TCG
>   target-i386: Define TCG_*_FEATURES earlier on cpu.c
>   target-i386: Loop-based feature word filtering in TCG mode
>   target-i386: Support check/enforce flags in TCG mode, too
> 
>  target-i386/cpu.c | 215 +++++++++++++++++++++++++++---------------------------
>  1 file changed, 107 insertions(+), 108 deletions(-)
> 

Reviewed-by: Richard Henderson <rth@twiddle.net>

r~