qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] hw/timer/grlib_gptimer: Avoid integer overflows
Date: Sun, 02 Mar 2014 16:56:25 +0100	[thread overview]
Message-ID: <531354A9.9020705@embedded-brains.de> (raw)
In-Reply-To: <53132F68.9070001@msgid.tls.msk.ru>

On 03/02/2014 02:17 PM, Michael Tokarev wrote:
> 26.02.2014 11:53, Sebastian Huber wrote:
>> Ping.
> There was another comment on this, about the first hunk,
> see https://lists.gnu.org/archive/html/qemu-trivial/2014-02/msg00067.html
>
> Note that the comment below this line mentions the +1 which is
> being removed.

I think I addressed this issue with the following sentence in the commit 
message of v2:

"Use the GPTIMER counter value for tracing to avoid an overflow of the 
32-bit value passed to trace_grlib_gptimer_enable()."

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber@embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.

  reply	other threads:[~2014-03-02 15:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-16 11:12 [Qemu-devel] [PATCH v2] hw/timer/grlib_gptimer: Avoid integer overflows Sebastian Huber
2014-02-26  7:53 ` Sebastian Huber
2014-03-02 13:17   ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-03-02 15:56     ` Sebastian Huber [this message]
2014-03-12  9:48       ` Sebastian Huber
2014-03-14 16:13 ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=531354A9.9020705@embedded-brains.de \
    --to=sebastian.huber@embedded-brains.de \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).