From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Andreas Schwab <schwab@suse.de>, Riku Voipio <riku.voipio@iki.fi>,
Alexander Graf <agraf@suse.de>, Michael Matz <matz@suse.de>,
patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 4/5] linux-user: Fix getresuid, getresgid if !USE_UID16
Date: Sun, 02 Mar 2014 22:05:33 +0100 [thread overview]
Message-ID: <53139D1D.7020703@suse.de> (raw)
In-Reply-To: <1393789002-29960-5-git-send-email-peter.maydell@linaro.org>
Am 02.03.2014 20:36, schrieb Peter Maydell:
> The size of the UID/GID types depends on whether USE_UID16 is
> defined. Define a new put_user_id() which writes a uid/gid
> type to guest memory. This fixes getresuid and getresgid, which
> were always storing 16 bits even if the uid type was 32 bits.
>
> Reported-by: Michael Matz <matz@suse.de>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> The SuSE 1.6 tree has a fix for this bug (hence the
> reported-by:) but I preferred to fix it in a different
> way to avoid introducing more ifdefs.
Looks sensible to me,
Reviewed-by: Andreas Färber <afaerber@suse.de>
Thanks,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2014-03-02 21:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-02 19:36 [Qemu-devel] [PATCH 0/5] linux-user: various fixes for AArch64 Peter Maydell
2014-03-02 19:36 ` [Qemu-devel] [PATCH 1/5] linux-user/signal.c: Fix AArch64 big-endian FP register restore Peter Maydell
2014-03-02 19:36 ` [Qemu-devel] [PATCH 2/5] linux-user: AArch64: Implement SA_RESTORER for signal handlers Peter Maydell
2014-03-02 19:36 ` [Qemu-devel] [PATCH 3/5] linux-user: Don't use UID16 on AArch64 Peter Maydell
2014-03-02 19:36 ` [Qemu-devel] [PATCH 4/5] linux-user: Fix getresuid, getresgid if !USE_UID16 Peter Maydell
2014-03-02 21:05 ` Andreas Färber [this message]
2014-03-02 19:36 ` [Qemu-devel] [PATCH 5/5] linux-user: Implement sendmmsg syscall Peter Maydell
2014-03-03 16:33 ` [Qemu-devel] [PATCH 0/5] linux-user: various fixes for AArch64 Richard Henderson
2014-03-03 21:10 ` Riku Voipio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53139D1D.7020703@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=matz@suse.de \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).