From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60609)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WKVlE-0004eV-Hq
	for qemu-devel@nongnu.org; Mon, 03 Mar 2014 11:30:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WKVl6-0002NA-JJ
	for qemu-devel@nongnu.org; Mon, 03 Mar 2014 11:30:36 -0500
Received: from cantor2.suse.de ([195.135.220.15]:41250 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WKVl6-0002N5-8X
	for qemu-devel@nongnu.org; Mon, 03 Mar 2014 11:30:28 -0500
Message-ID: <5314AE20.4040502@suse.de>
Date: Mon, 03 Mar 2014 17:30:24 +0100
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1392821892-26682-1-git-send-email-ehabkost@redhat.com>
	<20140219191311.GC24622@redhat.com>
In-Reply-To: <20140219191311.GC24622@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 0/3] Enable x2apic by default on KVM
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Bandan Das <bsd@redhat.com>, Anthony Liguori <aliguori@amazon.com>, Igor Mammedov <imammedo@redhat.com>, Richard Henderson <rth@twiddle.net>

Am 19.02.2014 20:13, schrieb Michael S. Tsirkin:
> On Wed, Feb 19, 2014 at 11:58:09AM -0300, Eduardo Habkost wrote:
>> This is the approach I believe was agreed upon during the last QEMU de=
velopers
>> conf call (sorry I didn't join, the meeting timezone change confused m=
e).
>=20
> Yes.

Matches my understanding as well.

>> Some may notice that representing this new behavior using solely defau=
lt values
>> on CPU properties may be a little difficult. Making it possible to rep=
lace
>> x86_cpu_compat_disable_kvm_features() with compat_props entries may be=
 an
>> interesting problem, too.
>=20
> Acked-by: Michael S. Tsirkin <mst@redhat.com>

Paolo clarified that he is okay with me going ahead with the series, so
let's get the behavior changed first and then we can later worry about
refactoring the compat infrastructure.

Thanks, applied to qom-cpu:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu

One question for 3/3 though: Is it "running KVM", "running on KVM",
"running in KVM" or "running with KVM"? I was unsure, so left it as is.

Regards,
Andreas

>> Eduardo Habkost (3):
>>   target-i386: Make kvm_default_features an array
>>   target-i386: Introduce x86_cpu_compat_disable_kvm_features()
>>   target-i386: Enable x2apic by default on KVM

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg