From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKXU6-0008Dz-Te for qemu-devel@nongnu.org; Mon, 03 Mar 2014 13:21:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WKXTn-0000au-U8 for qemu-devel@nongnu.org; Mon, 03 Mar 2014 13:21:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53027) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKXTn-0000aW-I6 for qemu-devel@nongnu.org; Mon, 03 Mar 2014 13:20:43 -0500 Message-ID: <5314C7F5.4010701@redhat.com> Date: Mon, 03 Mar 2014 11:20:37 -0700 From: Eric Blake MIME-Version: 1.0 References: <1393855031-26915-1-git-send-email-kwolf@redhat.com> <1393855031-26915-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1393855031-26915-3-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NsNSQer92fILOs2MQePcxWs30xEVIivsd" Subject: Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: Test progress output for conversion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: pl@kamp.de, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NsNSQer92fILOs2MQePcxWs30xEVIivsd Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/03/2014 06:57 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/086 | 65 ++++++++++++++++++++++++++++++++++++++= ++++++++ > tests/qemu-iotests/086.out | 18 +++++++++++++ > tests/qemu-iotests/group | 1 + > 3 files changed, 84 insertions(+) > create mode 100755 tests/qemu-iotests/086 > create mode 100644 tests/qemu-iotests/086.out >=20 > + > +$QEMU_IMG convert -p -O $IMGFMT -f $IMGFMT "$TEST_IMG" "$TEST_IMG".bas= e 2>&1 |\ > + _filter_testdir | sed -e 's/\r/\n/g' \r is not portable sed. Alas, coming up with a portable way to represent carriage return in sed is a bear, so I can live with this reliance on GNU sed. > +wrote 1048576/1048576 bytes at offset 33554432 > +1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > + (0.00/100%) > + (25.00/100%) > + (50.00/100%) > + (75.00/100%) > + (100.00/100%) > + (100.00/100%) Feels fragile (will it ALWAYS be done in chunks of 25% completion?) but if it passes reliably, it's always better to have more test coverage. Can we test the other commands that support -p? And is anyone interested in adding -p support to more commands (there are several long-running commands that could use it but don't have it yet). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --NsNSQer92fILOs2MQePcxWs30xEVIivsd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTFMf1AAoJEKeha0olJ0NqQvUH/A0KmvA8JHBGZVa2b/GJERW5 oMW9DfZiwZRezxIbYiUANHa0jzZ/htej6zIHwl0RDiBKdJMX/iYWg5r963gnMz/n YhuxlTRwTQuFxsPIqen26EgFIgCioVsnuMRXfd0cnpM3Q0BuT58Mn8PBDaU0DwQS yHMhNcEXH+1VgwBCr9IRcO6BShcEm83z3l5GYxgBfy7wsRUSzuZ5luy23DbRZ7j0 BIiK8DEMjciLVL0H8WwCFpC/PkmJW7NW/aQRjHmaXRR+PoiyvyAx6olBVUCRRdyc Xwn+H/KGYRpIaxLUOctWh0ejpYIfR1Fmw6LA9RLyRiNTFn4PPuw2lquHwopKICQ= =OAwF -----END PGP SIGNATURE----- --NsNSQer92fILOs2MQePcxWs30xEVIivsd--