From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40461)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WKXi2-000640-RH
	for qemu-devel@nongnu.org; Mon, 03 Mar 2014 13:35:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WKXhw-0006Sp-PD
	for qemu-devel@nongnu.org; Mon, 03 Mar 2014 13:35:26 -0500
Received: from mx1.redhat.com ([209.132.183.28]:20765)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WKXhw-0006Sk-Gm
	for qemu-devel@nongnu.org; Mon, 03 Mar 2014 13:35:20 -0500
Message-ID: <5314CB61.7090401@redhat.com>
Date: Mon, 03 Mar 2014 19:35:13 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1393870294-19351-1-git-send-email-benoit.canet@irqsave.net>
	<1393870294-19351-2-git-send-email-benoit.canet@irqsave.net>
In-Reply-To: <1393870294-19351-2-git-send-email-benoit.canet@irqsave.net>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] block: Rewrite the snapshot authorization
 mechanism for block filters.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-15?Q?Beno=EEt_Canet?= <benoit.canet@irqsave.net>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Benoit Canet <benoit@irqsave.net>, stefanha@redhat.com, mreitz@redhat.com

Il 03/03/2014 19:11, Beno=EEt Canet ha scritto:
> diff --git a/block/blkverify.c b/block/blkverify.c
> index b98b08b..e1c3117 100644
> --- a/block/blkverify.c
> +++ b/block/blkverify.c
> @@ -288,6 +288,20 @@ static BlockDriverAIOCB *blkverify_aio_flush(Block=
DriverState *bs,
>      return bdrv_aio_flush(s->test_file, cb, opaque);
>  }
>
> +static bool blkverify_recurse_is_first_non_filter(BlockDriverState *bs=
,
> +                                                  BlockDriverState *ca=
ndidate)
> +{
> +    BDRVBlkverifyState *s =3D bs->opaque;
> +
> +    bool perm =3D bdrv_recurse_is_first_non_filter(bs->file, candidate=
);
> +
> +    if (perm) {
> +        return true;
> +    }
> +
> +    return bdrv_recurse_is_first_non_filter(s->test_file, candidate);

Thanks!  Is this a silent bugfix? :)

It is a behavior change from before, because BS_FILTER_PASS_DOWN only=20
tested bs->file.

Paolo