From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48282)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WKYJV-0005qN-9E
	for qemu-devel@nongnu.org; Mon, 03 Mar 2014 14:14:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WKYJO-0001tU-H5
	for qemu-devel@nongnu.org; Mon, 03 Mar 2014 14:14:09 -0500
Received: from mail-qg0-x233.google.com ([2607:f8b0:400d:c04::233]:50249)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WKYJO-0001tQ-Cn
	for qemu-devel@nongnu.org; Mon, 03 Mar 2014 14:14:02 -0500
Received: by mail-qg0-f51.google.com with SMTP id q108so12528428qgd.10
	for <qemu-devel@nongnu.org>; Mon, 03 Mar 2014 11:14:02 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5314D475.8070107@redhat.com>
Date: Mon, 03 Mar 2014 20:13:57 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1393873716-9574-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
In-Reply-To: <1393873716-9574-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] hw/9pfs: Include virtio-9p-device.o in
	build
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>, qemu-devel@nongnu.org, Fam Zheng <famz@redhat.com>

Il 03/03/2014 20:08, Aneesh Kumar K.V ha scritto:
> From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
>
> After commit ba1183da9a10b94611cad88c44a5c6df005f9b55 we are including
> hw/Makefile.objs directly from Makefile.target. Hence we need to define
> the config in Makefile.target too to include virtio-9p-device.o in
> the build
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> ---
>  Makefile.target | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Makefile.target b/Makefile.target
> index ba1234063eae..da8daa82c39e 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -137,6 +137,10 @@ endif # CONFIG_SOFTMMU
>  # Workaround for http://gcc.gnu.org/PR55489, see configure.
>  %/translate.o: QEMU_CFLAGS += $(TRANSLATE_OPT_CFLAGS)
>
> +ifeq ($(CONFIG_VIRTIO)$(CONFIG_VIRTFS)$(CONFIG_PCI),yyy)
> +CONFIG_REALLY_VIRTFS=y
> +endif
> +
>  dummy := $(call unnest-vars,,obj-y)
>
>  # we are making another call to unnest-vars with different vars, protect obj-y,
>

Can you just replace $(CONFIG_REALLY_VIRTFS) with

$(call land, $(call land, $(CONFIG_VIRTIO),
                           $(CONFIG_VIRTFS)),
                           $(CONFIG_PCI))

in hw/Makefile.objs, and remove it from Makefile.objs?

Paolo